tree a391faa9d4e08162fa2d6f682ea7e5f22038d143
parent e5d2e67744d2de6726ad8dd60bb3ad0ac4c3f495
author Henri Chataing <henrichataing@google.com> 1709054835 +0000
committer Henri Chataing <henrichataing@google.com> 1709084369 +0000

RootCanal: Improve handling of packet parsing errors

Previously simply crashed with ASSERT when an invalid packet
was received. This was problematic for a couple reasons:
 - ASSERT is not always enabled, i.e. some code could be
   executed with invalid packets as input
 - in the android emulator context it is not desirable to
   crash the emulator when receiving an invalid packet

Instead, this patch uses the following handling code when
a parsing error is found
 - report the packet through the invalid packet handler
  (same as generating a bug report with a triggered ASSERT)
 - send a Hardware Error event to the Host to signal invalid
   behavior
 - if in debug mode trigger ASSERT, else ignore the packet

Bug: 323226412
Test: m root-canal
Flag: EXEMPT, tool change
Change-Id: Ibcb89b0fc7f405e3646cfd249a3fad88a668302b