commit 8f006edba228622422088a358aafee069e1d9cfb
author Adam Cohen <adamcohen@google.com> Thu Apr 03 18:12:34 2014 -0700
committer Adam Cohen <adamcohen@google.com> Thu Apr 03 18:14:30 2014 -0700
tree 2300610a482a13dab60f47797f6e279fda5e53e3
parent cc95d18d6ddeaf247b1f43659153edb1b3f315d7

Prevent exception in production when icons collide during bind

-> We only need to throw an exception for dogfooders so we can
   track the issue
-> Worst case, an icon is ignored, does not warrant a crash.

issue 12106766

Change-Id: I054a849eb3d65762dc5e1bf699c76655f687c3e8

src/com/android/launcher3/Launcher.java

diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java
index 5bdd7eb3..6474d26 100644
--- a/src/com/android/launcher3/Launcher.java
+++ b/src/com/android/launcher3/Launcher.java
@@ -3982,7 +3982,15 @@
                     if (item.container == LauncherSettings.Favorites.CONTAINER_DESKTOP) {
                         CellLayout cl = mWorkspace.getScreenWithId(item.screenId);
                         if (cl != null && cl.isOccupied(item.cellX, item.cellY)) {
-                            throw new RuntimeException("OCCUPIED");
+                            View v = cl.getChildAt(item.cellX, item.cellY);
+                            Object tag = v.getTag();
+                            String desc = "Collision while binding workspace item: " + item
+                                    + ". Collides with " + tag;
+                            if (LauncherAppState.isDogfoodBuild()) {
+                                throw (new RuntimeException(desc));
+                            } else {
+                                Log.d(TAG, desc);
+                            }
                         }
                     }