tree 2f9226bd215035a55a7933bd5bcbb286dc089d23
parent ddb446000590185459d543f66e9748880fc4c4c0
author Cole Faust <colefaust@google.com> 1665894807 -0700
committer Michael Bestas <mkbestas@lineageos.org> 1696859951 +0300
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQJLBAABCgA1FiEEHrBYPudH862glXQBzJUERRm+ZmkFAmUkBy8XHG1rYmVzdGFz
 QGxpbmVhZ2Vvcy5vcmcACgkQzJUERRm+Zmmomg//b+Az2ZxE4Avkss0mtS+fqOKR
 ytOtg4qzTQHQLMjsHXuArIhSnHy59APGgePaTtjrkPjvnOyX7SCljoNcJd4amPAN
 /KgVv4NLTQO0Lb95pMMPk/695veZGL4s9nQejn271zyjEPFXmPSn0rPI90mkuT29
 l2OfKYJBwKEqA6v4UcnwhNCSpRTwSFY3jM7NORXtgD3pwqt1CqSj40nNkrHamj/0
 0mtyIRSDGW5ua0iH0/8Lz2ZJMeaxLGdwJe5m0WxiDgnBK0tfpiUtcIeNIEjYLckD
 +WgZ9zF72cel5Nvjl0NTvTMs+usxQ6JhkpkV+gFh1FCfDDdD4sOfqttKxuupdu8w
 eGaD43NB5inPM1rxFo43Cd3m4zV2Xr1iP8pH9afNwh1a34wIfCowWBW7zhZn6o5p
 uGIPz12egYSVwQPHdgbZSJOWSJeSoqIiap73qn6EEG4rmnLAQPRD+4gaEKkgzAI1
 Lw3STljdphraIqdDiGa36vKed5dQOi5Ndv3GgoRnD1cAOfHfToQqjPsyQSTwEB8s
 va2pyvjdYnAWdxmYmUvQPJui4yiLBEQnriCI3/pY9UBJmozRcyIlljkWUIAq4Ajy
 69bw3C+zy1ArSmKlX/Ic3oTAg82PyQTLKhbrWklCFdqUE/HuFDNUFrPCHIcg3Dgd
 tAtoxlezzwWdBx9zhS8=
 =fPJN
 -----END PGP SIGNATURE-----

Fix errorprone warnings that should be errors

This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If22f7e827ef4d3e5766d6cc9f6a78353fbfaa60f