AOSP/Gallery2 - Updated to sdkVersion 29. Deleted usage of GROUP BY from the WHERE clause. Changed all COUNT(*) to COUNT(_id).
API 29 disallows SQL injection by trying to include it in a "WHERE" clause. Galley app is used for CTS testing and that doesn't require the GROUP BY clause.
BUG: 133177396
BUG: 143968106
BUG: 143667204 (verified this bug doesn't happen)
Test: manual - Ran the following on Pixel phone. Tested the gallery2 UI manually.
$ make -j 40
$ make Gallery2 -j
$ ls -l out/target/product/generic/system/product/app/Gallery2/Gallery2.apk
... 7608845 Nov 5 16:58 out/target/product/generic/system/product/app/Gallery2/Gallery2.apk
$ adb install -r -d -g out/target/product/generic/system/product/app/Gallery2/Gallery2.apk
Change-Id: I415a35130f017b4440b2f398bf9000d0159f30d6
5 files changed