commit 407afd32dc7cc6d0f9435d2269d8e680935e24db
author Yumi Yukimura <me.cafebabe@gmail.com> Wed Mar 20 23:52:03 2024 +0800
committer Michael Bestas <mkbestas@lineageos.org> Fri Mar 22 12:09:09 2024 +0000
tree 4966eb41785fdd5ceef75d9314e2790440bc77d3
parent 11798b3cfd2628ed8777c870d7450ee3b02a1dbe

usb: 1.3-basic: Implement enableUsbDataSignal method for legacy USB restrict

Change-Id: I657b2595777327c92ec88c168e93ff988162f546

usb/1.3-basic/Usb.cpp

diff --git a/usb/1.3-basic/Usb.cpp b/usb/1.3-basic/Usb.cpp
index 0edb0d4..4592dbd 100644
--- a/usb/1.3-basic/Usb.cpp
+++ b/usb/1.3-basic/Usb.cpp
@@ -19,6 +19,7 @@
 
 #define LOG_TAG "android.hardware.usb@1.3-service-basic"
 
+#include <android-base/file.h>
 #include <android-base/logging.h>
 #include <utils/Errors.h>
 #include <utils/StrongPointer.h>
@@ -131,9 +132,14 @@
 }
 
 // Methods from ::android::hardware::usb::V1_3::IUsb follow.
-Return<bool> Usb::enableUsbDataSignal(bool enable __unused) {
-    // TODO implement
-    return bool{};
+Return<bool> Usb::enableUsbDataSignal(bool enable) {
+    bool success =
+            android::base::WriteStringToFile(enable ? "0" : "1", "/proc/sys/kernel/deny_new_usb");
+    if (success)
+        queryPortStatus();
+    else
+        LOG(ERROR) << __func__ << ": Failed to " << (enable ? "enable" : "disable");
+    return success;
 }
 
 }  // namespace implementation

usb/1.3-basic/android.hardware.usb@1.3-service.basic.rc

diff --git a/usb/1.3-basic/android.hardware.usb@1.3-service.basic.rc b/usb/1.3-basic/android.hardware.usb@1.3-service.basic.rc
index d0ff95f..afa9293 100644
--- a/usb/1.3-basic/android.hardware.usb@1.3-service.basic.rc
+++ b/usb/1.3-basic/android.hardware.usb@1.3-service.basic.rc
@@ -4,5 +4,7 @@
     interface android.hardware.usb@1.2::IUsb default
     interface android.hardware.usb@1.3::IUsb default
     class hal
-    user system
-    group system
+    user root
+    group root
+
+# Note: Running as root user is required for writing to /proc/sys/kernel/deny_new_usb