Send <Report audio status> CEC commands when it's changed
According to HDMI CEC specification, an audio system
can report its audio status when System Audio Mode
is on, so that the TV can display the audio status
of external amplifier.
More details can be found in section CEC-13.15 of
HDMI Specification 1.4b
Bug: 80297383
Test: make; flashall; local tests
Change-Id: Id71b709a62add7bf5dccb418489e200350debb8e
diff --git a/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java b/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java
index 6b456f5..b27b4d8 100644
--- a/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java
+++ b/core/java/android/hardware/hdmi/HdmiAudioSystemClient.java
@@ -15,6 +15,8 @@
*/
package android.hardware.hdmi;
+import android.os.RemoteException;
+
/**
* HdmiAudioSystemClient represents HDMI-CEC logical device of type Audio System in the Android
* system which acts as an audio system device such as sound bar.
@@ -40,5 +42,20 @@
return HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM;
}
-
+ /**
+ * Sends a Report Audio Status HDMI CEC command to TV devices when necessary.
+ *
+ * According to HDMI CEC specification, an audio system can report its audio status when System
+ * Audio Mode is on, so that the TV can display the audio status of external amplifier.
+ *
+ * @hide
+ */
+ public void sendReportAudioStatusCecCommand(boolean isMuteAdjust, int volume, int maxVolume,
+ boolean isMute) {
+ try {
+ mService.reportAudioStatus(getDeviceType(), volume, maxVolume, isMute);
+ } catch (RemoteException e) {
+ // do nothing. Reporting audio status is optional.
+ }
+ }
}
diff --git a/core/java/android/hardware/hdmi/IHdmiControlService.aidl b/core/java/android/hardware/hdmi/IHdmiControlService.aidl
index 67e2d18..2b8d00b 100644
--- a/core/java/android/hardware/hdmi/IHdmiControlService.aidl
+++ b/core/java/android/hardware/hdmi/IHdmiControlService.aidl
@@ -72,4 +72,5 @@
void sendMhlVendorCommand(int portId, int offset, int length, in byte[] data);
void addHdmiMhlVendorCommandListener(IHdmiMhlVendorCommandListener listener);
void setStandbyMode(boolean isStandbyModeOn);
+ void reportAudioStatus(int deviceType, int volume, int maxVolume, boolean isMute);
}
diff --git a/services/core/java/com/android/server/audio/AudioService.java b/services/core/java/com/android/server/audio/AudioService.java
index d1fd0d5..6bebbe2 100644
--- a/services/core/java/com/android/server/audio/AudioService.java
+++ b/services/core/java/com/android/server/audio/AudioService.java
@@ -57,6 +57,7 @@
import android.content.res.Resources;
import android.content.res.XmlResourceParser;
import android.database.ContentObserver;
+import android.hardware.hdmi.HdmiAudioSystemClient;
import android.hardware.hdmi.HdmiControlManager;
import android.hardware.hdmi.HdmiPlaybackClient;
import android.hardware.hdmi.HdmiTvClient;
@@ -926,14 +927,15 @@
}
if (mContext.getPackageManager().hasSystemFeature(PackageManager.FEATURE_HDMI_CEC)) {
- mHdmiManager = mContext.getSystemService(HdmiControlManager.class);
- synchronized (mHdmiManager) {
+ synchronized (mHdmiClientLock) {
+ mHdmiManager = mContext.getSystemService(HdmiControlManager.class);
mHdmiTvClient = mHdmiManager.getTvClient();
if (mHdmiTvClient != null) {
mFixedVolumeDevices &= ~AudioSystem.DEVICE_ALL_HDMI_SYSTEM_AUDIO_AND_SPEAKER;
}
mHdmiPlaybackClient = mHdmiManager.getPlaybackClient();
mHdmiCecSink = false;
+ mHdmiAudioSystemClient = mHdmiManager.getAudioSystemClient();
}
}
@@ -1054,11 +1056,9 @@
sendEncodedSurroundMode(mContentResolver, "onAudioServerDied");
sendEnabledSurroundFormats(mContentResolver, true);
}
- if (mHdmiManager != null) {
- synchronized (mHdmiManager) {
- if (mHdmiTvClient != null) {
- setHdmiSystemAudioSupported(mHdmiSystemAudioSupported);
- }
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null && mHdmiTvClient != null) {
+ setHdmiSystemAudioSupported(mHdmiSystemAudioSupported);
}
}
@@ -1763,24 +1763,31 @@
if (streamTypeAlias == AudioSystem.STREAM_MUSIC) {
setSystemAudioVolume(oldIndex, newIndex, getStreamMaxVolume(streamType), flags);
}
- if (mHdmiManager != null) {
- synchronized (mHdmiManager) {
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null) {
// mHdmiCecSink true => mHdmiPlaybackClient != null
if (mHdmiCecSink &&
streamTypeAlias == AudioSystem.STREAM_MUSIC &&
oldIndex != newIndex) {
- synchronized (mHdmiPlaybackClient) {
- int keyCode = (direction == -1) ? KeyEvent.KEYCODE_VOLUME_DOWN :
- KeyEvent.KEYCODE_VOLUME_UP;
- final long ident = Binder.clearCallingIdentity();
- try {
- mHdmiPlaybackClient.sendKeyEvent(keyCode, true);
- mHdmiPlaybackClient.sendKeyEvent(keyCode, false);
- } finally {
- Binder.restoreCallingIdentity(ident);
- }
+ int keyCode = (direction == -1) ? KeyEvent.KEYCODE_VOLUME_DOWN :
+ KeyEvent.KEYCODE_VOLUME_UP;
+ final long ident = Binder.clearCallingIdentity();
+ try {
+ mHdmiPlaybackClient.sendKeyEvent(keyCode, true);
+ mHdmiPlaybackClient.sendKeyEvent(keyCode, false);
+ } finally {
+ Binder.restoreCallingIdentity(ident);
}
}
+
+ if (mHdmiAudioSystemClient != null &&
+ streamTypeAlias == AudioSystem.STREAM_MUSIC &&
+ (oldIndex != newIndex || isMuteAdjust)) {
+ mHdmiAudioSystemClient.sendReportAudioStatusCecCommand(
+ isMuteAdjust, getStreamVolume(AudioSystem.STREAM_MUSIC),
+ getStreamMaxVolume(AudioSystem.STREAM_MUSIC),
+ isStreamMute(AudioSystem.STREAM_MUSIC));
+ }
}
}
}
@@ -1799,22 +1806,19 @@
}
private void setSystemAudioVolume(int oldVolume, int newVolume, int maxVolume, int flags) {
- if (mHdmiManager == null
- || mHdmiTvClient == null
- || oldVolume == newVolume
- || (flags & AudioManager.FLAG_HDMI_SYSTEM_AUDIO_VOLUME) != 0) return;
-
// Sets the audio volume of AVR when we are in system audio mode. The new volume info
// is tranformed to HDMI-CEC commands and passed through CEC bus.
- synchronized (mHdmiManager) {
- if (!mHdmiSystemAudioSupported) return;
- synchronized (mHdmiTvClient) {
- final long token = Binder.clearCallingIdentity();
- try {
- mHdmiTvClient.setSystemAudioVolume(oldVolume, newVolume, maxVolume);
- } finally {
- Binder.restoreCallingIdentity(token);
- }
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager == null
+ || mHdmiTvClient == null
+ || oldVolume == newVolume
+ || (flags & AudioManager.FLAG_HDMI_SYSTEM_AUDIO_VOLUME) != 0
+ || !mHdmiSystemAudioSupported) return;
+ final long token = Binder.clearCallingIdentity();
+ try {
+ mHdmiTvClient.setSystemAudioVolume(oldVolume, newVolume, maxVolume);
+ } finally {
+ Binder.restoreCallingIdentity(token);
}
}
}
@@ -2037,6 +2041,17 @@
index = mStreamStates[streamType].getIndex(device);
}
}
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null &&
+ mHdmiAudioSystemClient != null &&
+ streamTypeAlias == AudioSystem.STREAM_MUSIC &&
+ (oldIndex != index)) {
+ mHdmiAudioSystemClient.sendReportAudioStatusCecCommand(
+ false, getStreamVolume(AudioSystem.STREAM_MUSIC),
+ getStreamMaxVolume(AudioSystem.STREAM_MUSIC),
+ isStreamMute(AudioSystem.STREAM_MUSIC));
+ }
+ }
sendVolumeUpdate(streamType, oldIndex, index, flags);
}
@@ -2177,8 +2192,8 @@
// If Hdmi-CEC system audio mode is on, we show volume bar only when TV
// receives volume notification from Audio Receiver.
private int updateFlagsForSystemAudio(int flags) {
- if (mHdmiTvClient != null) {
- synchronized (mHdmiTvClient) {
+ synchronized (mHdmiClientLock) {
+ if (mHdmiTvClient != null) {
if (mHdmiSystemAudioSupported &&
((flags & AudioManager.FLAG_HDMI_SYSTEM_AUDIO_VOLUME) == 0)) {
flags &= ~AudioManager.FLAG_SHOW_UI;
@@ -2233,16 +2248,13 @@
}
private void setSystemAudioMute(boolean state) {
- if (mHdmiManager == null || mHdmiTvClient == null) return;
- synchronized (mHdmiManager) {
- if (!mHdmiSystemAudioSupported) return;
- synchronized (mHdmiTvClient) {
- final long token = Binder.clearCallingIdentity();
- try {
- mHdmiTvClient.setSystemAudioMute(state);
- } finally {
- Binder.restoreCallingIdentity(token);
- }
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager == null || mHdmiTvClient == null || !mHdmiSystemAudioSupported) return;
+ final long token = Binder.clearCallingIdentity();
+ try {
+ mHdmiTvClient.setSystemAudioMute(state);
+ } finally {
+ Binder.restoreCallingIdentity(token);
}
}
}
@@ -6370,12 +6382,10 @@
if (isPlatformTelevision() && ((device & AudioSystem.DEVICE_OUT_HDMI) != 0)) {
mFixedVolumeDevices |= AudioSystem.DEVICE_OUT_HDMI;
checkAllFixedVolumeDevices();
- if (mHdmiManager != null) {
- synchronized (mHdmiManager) {
- if (mHdmiPlaybackClient != null) {
- mHdmiCecSink = false;
- mHdmiPlaybackClient.queryDisplayStatus(mHdmiDisplayStatusCallback);
- }
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null && mHdmiPlaybackClient != null) {
+ mHdmiCecSink = false;
+ mHdmiPlaybackClient.queryDisplayStatus(mHdmiDisplayStatusCallback);
}
}
}
@@ -6384,8 +6394,8 @@
}
} else {
if (isPlatformTelevision() && ((device & AudioSystem.DEVICE_OUT_HDMI) != 0)) {
- if (mHdmiManager != null) {
- synchronized (mHdmiManager) {
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null) {
mHdmiCecSink = false;
}
}
@@ -7054,8 +7064,8 @@
private class MyDisplayStatusCallback implements HdmiPlaybackClient.DisplayStatusCallback {
public void onComplete(int status) {
- if (mHdmiManager != null) {
- synchronized (mHdmiManager) {
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null) {
mHdmiCecSink = (status != HdmiControlManager.POWER_STATUS_UNKNOWN);
// Television devices without CEC service apply software volume on HDMI output
if (isPlatformTelevision() && !mHdmiCecSink) {
@@ -7065,43 +7075,49 @@
}
}
}
- };
+ }
+
+ private final Object mHdmiClientLock = new Object();
// If HDMI-CEC system audio is supported
private boolean mHdmiSystemAudioSupported = false;
// Set only when device is tv.
+ @GuardedBy("mHdmiClientLock")
private HdmiTvClient mHdmiTvClient;
// true if the device has system feature PackageManager.FEATURE_LEANBACK.
// cached HdmiControlManager interface
+ @GuardedBy("mHdmiClientLock")
private HdmiControlManager mHdmiManager;
// Set only when device is a set-top box.
+ @GuardedBy("mHdmiClientLock")
private HdmiPlaybackClient mHdmiPlaybackClient;
// true if we are a set-top box, an HDMI sink is connected and it supports CEC.
private boolean mHdmiCecSink;
+ // Set only when device is an audio system.
+ @GuardedBy("mHdmiClientLock")
+ private HdmiAudioSystemClient mHdmiAudioSystemClient;
private MyDisplayStatusCallback mHdmiDisplayStatusCallback = new MyDisplayStatusCallback();
@Override
public int setHdmiSystemAudioSupported(boolean on) {
int device = AudioSystem.DEVICE_NONE;
- if (mHdmiManager != null) {
- synchronized (mHdmiManager) {
+ synchronized (mHdmiClientLock) {
+ if (mHdmiManager != null) {
if (mHdmiTvClient == null) {
Log.w(TAG, "Only Hdmi-Cec enabled TV device supports system audio mode.");
return device;
}
- synchronized (mHdmiTvClient) {
- if (mHdmiSystemAudioSupported != on) {
- mHdmiSystemAudioSupported = on;
- final int config = on ? AudioSystem.FORCE_HDMI_SYSTEM_AUDIO_ENFORCED :
- AudioSystem.FORCE_NONE;
- mForceUseLogger.log(new ForceUseEvent(AudioSystem.FOR_HDMI_SYSTEM_AUDIO,
- config, "setHdmiSystemAudioSupported"));
- AudioSystem.setForceUse(AudioSystem.FOR_HDMI_SYSTEM_AUDIO, config);
- }
- device = getDevicesForStream(AudioSystem.STREAM_MUSIC);
+ if (mHdmiSystemAudioSupported != on) {
+ mHdmiSystemAudioSupported = on;
+ final int config = on ? AudioSystem.FORCE_HDMI_SYSTEM_AUDIO_ENFORCED :
+ AudioSystem.FORCE_NONE;
+ mForceUseLogger.log(new ForceUseEvent(AudioSystem.FOR_HDMI_SYSTEM_AUDIO,
+ config, "setHdmiSystemAudioSupported"));
+ AudioSystem.setForceUse(AudioSystem.FOR_HDMI_SYSTEM_AUDIO, config);
}
+ device = getDevicesForStream(AudioSystem.STREAM_MUSIC);
}
}
return device;
diff --git a/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java b/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java
index bf392aa..1900b2d 100644
--- a/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java
+++ b/services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceAudioSystem.java
@@ -38,6 +38,7 @@
// Whether the System Audio Control feature is enabled or not. True by default.
@GuardedBy("mLock")
private boolean mSystemAudioControlFeatureEnabled;
+ protected Integer mSystemAudioSource;
protected HdmiCecLocalDeviceAudioSystem(HdmiControlService service) {
super(service, HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM);
@@ -183,7 +184,7 @@
mService.getAudioManager().adjustStreamVolume(AudioManager.STREAM_MUSIC,
systemAudioStatusOn ? AudioManager.ADJUST_UNMUTE : AudioManager.ADJUST_MUTE, 0);
}
-
+ mSystemAudioSource = systemAudioStatusOn ? message.getSource() : null;
mService.sendCecCommand(HdmiCecMessageBuilder
.buildSetSystemAudioMode(mAddress, Constants.ADDR_BROADCAST, systemAudioStatusOn));
return true;
diff --git a/services/core/java/com/android/server/hdmi/HdmiControlService.java b/services/core/java/com/android/server/hdmi/HdmiControlService.java
index 14807e9..16d346a 100644
--- a/services/core/java/com/android/server/hdmi/HdmiControlService.java
+++ b/services/core/java/com/android/server/hdmi/HdmiControlService.java
@@ -1717,6 +1717,38 @@
}
@Override
+ public void reportAudioStatus(final int deviceType, final int volume, final int maxVolume,
+ final boolean isMute) {
+ enforceAccessPermission();
+ runOnServiceThread(new Runnable() {
+ @Override
+ public void run() {
+ HdmiCecLocalDevice device = mCecController.getLocalDevice(deviceType);
+ if (device == null) {
+ Slog.w(TAG, "Local device not available");
+ return;
+ }
+ if (audioSystem() == null) {
+ Slog.w(TAG, "audio system is not available");
+ return;
+ }
+ if (audioSystem().mSystemAudioSource == null) {
+ Slog.w(TAG, "audio system is not in system audio mode");
+ return;
+ }
+ int scaledVolume = VolumeControlAction.scaleToCecVolume(volume, maxVolume);
+
+ sendCecCommand(HdmiCecMessageBuilder
+ .buildReportAudioStatus(
+ device.getDeviceInfo().getLogicalAddress(),
+ audioSystem().mSystemAudioSource,
+ scaledVolume,
+ isMute));
+ }
+ });
+ }
+
+ @Override
protected void dump(FileDescriptor fd, final PrintWriter writer, String[] args) {
if (!DumpUtils.checkDumpPermission(getContext(), TAG, writer)) return;
final IndentingPrintWriter pw = new IndentingPrintWriter(writer, " ");
@@ -2018,6 +2050,11 @@
mCecController.getLocalDevice(HdmiDeviceInfo.DEVICE_PLAYBACK);
}
+ public HdmiCecLocalDeviceAudioSystem audioSystem() {
+ return (HdmiCecLocalDeviceAudioSystem) mCecController.getLocalDevice(
+ HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM);
+ }
+
AudioManager getAudioManager() {
return (AudioManager) getContext().getSystemService(Context.AUDIO_SERVICE);
}