commit b93d234952704ac8acfe785364acc6bdafa2273a
author Yohei Yukawa <yukawa@google.com> Thu Jan 20 20:41:46 2022 -0800
committer Yohei Yukawa <yukawa@google.com> Thu Jan 20 20:41:46 2022 -0800
tree 19240183242e5c3c96e2aa60479b4df93634cb48
parent 79cad7881cc781adbc0217a4e825a1bd5f5a414b

Remove IMMS#MSG_BIND_INPUT

This CL inlines

  InputMethodManagerService#MSG_BIND_INPUT

handler as it has always been executed from the calling thread.

There should be no observable behavior change.

Bug: 215609403
Test: presubmit
Change-Id: Iab2c7f3bb3b41064359ea4100622e516670bfffc

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
index 1679421..3e77a77 100644
--- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
@@ -221,7 +221,6 @@
     private static final int MSG_SHOW_IM_SUBTYPE_PICKER = 1;
     private static final int MSG_SHOW_IM_CONFIG = 3;
 
-    private static final int MSG_BIND_INPUT = 1010;
     private static final int MSG_SHOW_SOFT_INPUT = 1020;
     private static final int MSG_HIDE_SOFT_INPUT = 1030;
     private static final int MSG_HIDE_CURRENT_INPUT_METHOD = 1035;
@@ -2304,8 +2303,10 @@
     InputBindResult attachNewInputLocked(@StartInputReason int startInputReason, boolean initial) {
         if (!mBoundToMethod) {
             IInputMethod curMethod = getCurMethodLocked();
-            executeOrSendMessage(curMethod, mCaller.obtainMessageOO(
-                    MSG_BIND_INPUT, curMethod, mCurClient.binding));
+            try {
+                curMethod.bindInput(mCurClient.binding);
+            } catch (RemoteException e) {
+            }
             mBoundToMethod = true;
         }
 
@@ -4227,14 +4228,6 @@
 
             // ---------------------------------------------------------
 
-            case MSG_BIND_INPUT:
-                args = (SomeArgs)msg.obj;
-                try {
-                    ((IInputMethod)args.arg1).bindInput((InputBinding)args.arg2);
-                } catch (RemoteException e) {
-                }
-                args.recycle();
-                return true;
             case MSG_SHOW_SOFT_INPUT:
                 args = (SomeArgs) msg.obj;
                 try {