commit af0cef987da359955023fde97f0f4c7444fd5e76
author Tobias Thierer <tobiast@google.com> Fri Sep 27 17:08:49 2019 +0100
committer Tobias Thierer <tobiast@google.com> Fri Sep 27 17:25:13 2019 +0100
tree 30db49b5b36201af0be76fb31083ea51405a48db
parent fd9657d0320f291fb96b58d7fd5cc46b59d35128

MimeMapImpl.createDefaultInstance() -> DefaultMimeMapFactory.create().

The class no longer implements MimeMap, so the name MimeMapImpl
no longer made sense.

Test: Treehugger
Bug: 136256059
Change-Id: I2cbc70a7769232b704a9bdfde2def832c1e292b8

core/java/com/android/internal/os/RuntimeInit.java

diff --git a/core/java/com/android/internal/os/RuntimeInit.java b/core/java/com/android/internal/os/RuntimeInit.java
index 89b0250..9fff447 100644
--- a/core/java/com/android/internal/os/RuntimeInit.java
+++ b/core/java/com/android/internal/os/RuntimeInit.java
@@ -20,7 +20,7 @@
 import android.app.ActivityManager;
 import android.app.ActivityThread;
 import android.app.ApplicationErrorReport;
-import android.content.type.MimeMapImpl;
+import android.content.type.DefaultMimeMapFactory;
 import android.os.Build;
 import android.os.DeadObjectException;
 import android.os.Debug;
@@ -209,7 +209,7 @@
          * contains many more entries that are derived from IANA registrations but
          * with several customizations (extensions, overrides).
          */
-        MimeMap.setDefault(MimeMapImpl.createDefaultInstance());
+        MimeMap.setDefault(DefaultMimeMapFactory.create());
     }
 
     @UnsupportedAppUsage

mime/Android.bp

diff --git a/mime/Android.bp b/mime/Android.bp
index 9303755..17bad74 100644
--- a/mime/Android.bp
+++ b/mime/Android.bp
@@ -20,7 +20,7 @@
     ],
 
     srcs: [
-        "java/android/content/type/MimeMapImpl.java",
+        "java/android/content/type/DefaultMimeMapFactory.java",
     ],
 
     java_resources: [

mime/java/android/content/type/DefaultMimeMapFactory.java

diff --git a/mime/java/android/content/type/MimeMapImpl.java b/mime/java/android/content/type/DefaultMimeMapFactory.java
similarity index 84%
rename from mime/java/android/content/type/MimeMapImpl.java
rename to mime/java/android/content/type/DefaultMimeMapFactory.java
index 3671603..545fb3c 100644
--- a/mime/java/android/content/type/MimeMapImpl.java
+++ b/mime/java/android/content/type/DefaultMimeMapFactory.java
@@ -26,21 +26,24 @@
 import java.util.regex.Pattern;
 
 /**
- * Default implementation of {@link MimeMap}, a bidirectional mapping between
- * MIME types and file extensions.
+ * Creates the framework default {@link MimeMap}, a bidirectional mapping
+ * between MIME types and file extensions.
  *
  * This default mapping is loaded from data files that start with some mappings
  * recognized by IANA plus some custom extensions and overrides.
  *
  * @hide
  */
-public class MimeMapImpl {
+public class DefaultMimeMapFactory {
+
+    private DefaultMimeMapFactory() {
+    }
 
     /**
-     * Creates and returns a new {@link MimeMapImpl} instance that implements.
+     * Creates and returns a new {@link MimeMap} instance that implements.
      * Android's default mapping between MIME types and extensions.
      */
-    public static MimeMap createDefaultInstance() {
+    public static MimeMap create() {
         return parseFromResources("/mime.types", "/android.mime.types");
     }
 
@@ -56,7 +59,7 @@
 
     private static void parseTypes(MimeMap.Builder builder, String resource) {
         try (BufferedReader r = new BufferedReader(
-                new InputStreamReader(MimeMapImpl.class.getResourceAsStream(resource)))) {
+                new InputStreamReader(DefaultMimeMapFactory.class.getResourceAsStream(resource)))) {
             String line;
             while ((line = r.readLine()) != null) {
                 int commentPos = line.indexOf('#');