commit 684f5a51b41ba326033808bad195a30775aef48a
author Michael Wright <michaelwr@google.com> Fri Feb 04 21:41:04 2022 +0000
committer Michael Wright <michaelwr@google.com> Fri Feb 04 21:41:04 2022 +0000
tree b25cd25e2297fa3d77176e6c92fa0f593f0bd6e1
parent 3cc84d0caa1d4c8556db1246888b9a0ce7b035b4

Remove instances of identical operands in binary expression

These are almost certainly all bugs. Removing them and enabling the
errorprone warning as an error going forward will hopefully avoid
further instances creeping in to the code base.

Bug: 217923092
Test: atest AdbDebuggingManagerTest AppTransitionControllerTest
      errorprone build
Change-Id: I51fb57024eb19f1b4c96b2033bbafdb610ef2ebb

services/Android.bp

diff --git a/services/Android.bp b/services/Android.bp
index 4dcf7d4..1bb283e 100644
--- a/services/Android.bp
+++ b/services/Android.bp
@@ -24,6 +24,7 @@
             "-Xep:ArrayHashCode:ERROR",
             "-Xep:SelfAssignment:ERROR",
             "-Xep:ArrayEquals:ERROR",
+            "-Xep:IdentityBinaryExpression:ERROR",
             // NOTE: only enable to generate local patchfiles
             // "-XepPatchChecks:refaster:frameworks/base/errorprone/refaster/EfficientXml.java.refaster",
             // "-XepPatchLocation:/tmp/refaster/",