commit 400ea8828105f6ce564fa48434ecf5116cf68f93
author Michael Wright <michaelwr@google.com> Fri Feb 04 20:45:04 2022 +0000
committer Michael Wright <michaelwr@google.com> Fri Feb 04 21:17:09 2022 +0000
tree 07149ebbea67cba4af3cf27a4448fafc285a05a2
parent 5c97595aafa51cd11c609afe31a848f20cf908ee

Use correct contains method in PermissionManagerService.

Hashtable#contains(String) is actually pre-generics method that maps to
Hashtable#containsValue(V). In this case, PermissionManagerService
actually wants to know if it contains a given key as the values in the
map are not Strings at all.

Bug: 217923092
Test: errorprone build
Change-Id: I1f315d1051aaab3831eaca34e12fc9858ee9aeda

services/Android.bp

diff --git a/services/Android.bp b/services/Android.bp
index 378ad54..654e8d0 100644
--- a/services/Android.bp
+++ b/services/Android.bp
@@ -19,6 +19,7 @@
             "-Xep:SelfEquals:ERROR",
             "-Xep:NullTernary:ERROR",
             "-Xep:TryFailThrowable:ERROR",
+            "-Xep:HashtableContains:ERROR",
             // NOTE: only enable to generate local patchfiles
             // "-XepPatchChecks:refaster:frameworks/base/errorprone/refaster/EfficientXml.java.refaster",
             // "-XepPatchLocation:/tmp/refaster/",