commit 16451b0b8dfdb095784dede8160a6cb34e2370ea
author Michael Wright <michaelwr@google.com> Fri Feb 04 20:59:26 2022 +0000
committer Michael Wright <michaelwr@google.com> Fri Feb 04 21:17:10 2022 +0000
tree 65ddbf566fc70fbf30692114f7b6852b1826d475
parent c92adae8a3a686b38426372a33b8eee8c6da35bf

Use Arrays.hashCode in EventIndex hashCode()

The hashCode method on arrays does not actually hash the array contents
but instead is just the identity of the array itself. This will return
erroneous results for objects that are equal but not the exact same
instance.

Bug: 217923092
Test: errorprone build
Change-Id: Idfcc220da5fb07a9b24a7b12795466303b14e35a

services/Android.bp

diff --git a/services/Android.bp b/services/Android.bp
index b40034a..db233e5 100644
--- a/services/Android.bp
+++ b/services/Android.bp
@@ -21,6 +21,7 @@
             "-Xep:TryFailThrowable:ERROR",
             "-Xep:HashtableContains:ERROR",
             "-Xep:FormatString:ERROR",
+            "-Xep:ArrayHashCode:ERROR",
             // NOTE: only enable to generate local patchfiles
             // "-XepPatchChecks:refaster:frameworks/base/errorprone/refaster/EfficientXml.java.refaster",
             // "-XepPatchLocation:/tmp/refaster/",