| commit | bb2b54f19e202d5781ec6c05b3d584fcd85cddcc | [log] [tgz] |
|---|---|---|
| author | Pierre-Clément Tosi <ptosi@google.com> | Fri Oct 06 14:39:12 2023 +0100 |
| committer | Pierre-Clément Tosi <ptosi@google.com> | Wed Oct 11 18:31:44 2023 +0100 |
| tree | 6d6c5c679a5ccf01f9ec1b7c37e4d4002289446e | |
| parent | 824645385979cf00626c048fcc5443e7209af458 [diff] |
ANDROID: Revert "Fix integer wrap sanitisation."
This reverts commit 0e783e26f75c08e421467ca4a6c21ff2589cd2fa.
Revert the patch we've had in Android now that upstream has [1]
commit 73590342fc85 ("libfdt: prevent integer overflow in fdt_next_tag")
which addresses the same bug.
As that patch is less rigorous w.r.t. the final value of 'offset' than
the one, the last 'if' is upstreamed by [2], which will be cherry-picked
here.
[1]: https://android.googlesource.com/platform/external/dtc/+/73590342fc85ca207ca1e6cbc110179873a96962
[2]: https://lore.kernel.org/devicetree-compiler/20231011172427.g4tlsew3wsjtddil@google.com/
Test: N/A
Change-Id: I662a599713b4090abd090322bca0a78e58f4c92c
The source tree contains the Device Tree Compiler (dtc) toolchain for working with device tree source and binary files and also libfdt, a utility library for reading and manipulating the binary format.
dtc and libfdt are maintained by:
A Python library wrapping libfdt is also available. To build this you will need to install swig and Python development files. On Debian distributions:
$ sudo apt-get install swig python3-dev
The library provides an Fdt class which you can use like this:
$ PYTHONPATH=../pylibfdt python3
>>> import libfdt
>>> fdt = libfdt.Fdt(open('test_tree1.dtb', mode='rb').read())
>>> node = fdt.path_offset('/subnode@1')
>>> print(node)
124
>>> prop_offset = fdt.first_property_offset(node)
>>> prop = fdt.get_property_by_offset(prop_offset)
>>> print('%s=%s' % (prop.name, prop.as_str()))
compatible=subnode1
>>> node2 = fdt.path_offset('/')
>>> print(fdt.getprop(node2, 'compatible').as_str())
test_tree1
You will find tests in tests/pylibfdt_tests.py showing how to use each method. Help is available using the Python help command, e.g.:
$ cd pylibfdt $ python3 -c "import libfdt; help(libfdt)"
If you add new features, please check code coverage:
$ sudo apt-get install python3-coverage $ cd tests # It's just 'coverage' on most other distributions $ python3-coverage run pylibfdt_tests.py $ python3-coverage html # Open 'htmlcov/index.html' in your browser
The library can be installed with pip from a local source tree:
$ pip install . [--user|--prefix=/path/to/install_dir]
Or directly from a remote git repo:
$ pip install git+git://git.kernel.org/pub/scm/utils/dtc/dtc.git@main
The install depends on libfdt shared library being installed on the host system first. Generally, using --user or --prefix is not necessary and pip will use the default location for the Python installation which varies if the user is root or not.
You can also install everything via make if you like, but pip is recommended.
To install both libfdt and pylibfdt you can use:
$ make install [PREFIX=/path/to/install_dir]
To disable building the python library, even if swig and Python are available, use:
$ make NO_PYTHON=1
More work remains to support all of libfdt, including access to numeric values.