commit e3c1ede68006c8c695ff5b7f6383d6aaef49f932
author Mathieu Chartier <mathieuc@google.com> Fri Jan 08 13:30:04 2021 -0800
committer Mathieu Chartier <mathieuc@google.com> Wed Jan 20 01:03:35 2021 +0000
tree 78eb12669b64f9a582371de17f71f46167f0350c
parent c6e4578e546bc23272cb165baff395cdac7521fc

Allow reserved_ memmap to be invalid for heap test

In some cases the mapping fails (presumably due to ASLR). Avoid
testing it's valid to prevent test flakiness.

Test: test.py
Bug: 175018342
Change-Id: Ia177a62ffa2158e1c3e93d30e71f35fb3dc73158

runtime/gc/heap_test.cc

diff --git a/runtime/gc/heap_test.cc b/runtime/gc/heap_test.cc
index 817c876..5e8c1e3 100644
--- a/runtime/gc/heap_test.cc
+++ b/runtime/gc/heap_test.cc
@@ -42,7 +42,7 @@
                                      /*reuse=*/ false,
                                      /*reservation=*/ nullptr,
                                      &error_msg);
-    ASSERT_TRUE(reserved_.IsValid()) << error_msg;
+    // There is no guarantee that reserved_ will be valid (due to ASLR). See b/175018342.
     CommonRuntimeTest::SetUp();
   }