commit e300c4e4eabe3388b730efe35561e54f1c306710
author Vladimir Marko <vmarko@google.com> Tue Jun 08 16:00:05 2021 +0100
committer Vladimir Marko <vmarko@google.com> Thu Jun 10 13:47:14 2021 +0000
tree 1866d5772e2c3643f30aa32b7bf0c02cec2e4c18
parent f761f5887918375b842e4cc62ed9cbe7521c8444

Faster Class::FindField().

Change `Class::FindField()` to take dex cache and type index
arguments instead of strings and optimize it similarly to
`Class::FindClassMethod()`, namely search by indexes when
possible (except when searching interfaces where we only add
a TODO comment for now) and avoid `strlen()` calls for ASCII
names and type descriptors.

Update `ClassLinker::FindResolvedFieldJLS()` to pass the new
arguments and replace all other `Class::FindField()` calls
with more direct calls as we know the classes where those
fields are defined.

Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Bug: 181943478
Change-Id: Iba798819043eb1b53b0dbc41ef8d7fd1c5d2164d

runtime/transaction_test.cc

diff --git a/runtime/transaction_test.cc b/runtime/transaction_test.cc
index ee7c591..f606d02 100644
--- a/runtime/transaction_test.cc
+++ b/runtime/transaction_test.cc
@@ -627,15 +627,13 @@
       class_linker_->FindClass(soa.Self(), "Ljava/lang/Boolean;", class_loader));
   ASSERT_TRUE(boolean_class != nullptr);
   ASSERT_TRUE(heap->ObjectIsInBootImageSpace(boolean_class.Get()));
-  ArtField* true_field =
-      mirror::Class::FindField(soa.Self(), boolean_class.Get(), "TRUE", "Ljava/lang/Boolean;");
+  ArtField* true_field = boolean_class->FindDeclaredStaticField("TRUE", "Ljava/lang/Boolean;");
   ASSERT_TRUE(true_field != nullptr);
   ASSERT_TRUE(true_field->IsStatic());
   Handle<mirror::Object> true_value = hs.NewHandle(true_field->GetObject(boolean_class.Get()));
   ASSERT_TRUE(true_value != nullptr);
   ASSERT_TRUE(heap->ObjectIsInBootImageSpace(true_value.Get()));
-  ArtField* value_field =
-      mirror::Class::FindField(soa.Self(), boolean_class.Get(), "value", "Z");
+  ArtField* value_field = boolean_class->FindDeclaredInstanceField("value", "Z");
   ASSERT_TRUE(value_field != nullptr);
   ASSERT_FALSE(value_field->IsStatic());
 
@@ -643,8 +641,7 @@
       class_linker_->FindClass(soa.Self(), "LTransaction$StaticFieldClass;", class_loader)));
   ASSERT_TRUE(static_field_class != nullptr);
   ASSERT_FALSE(heap->ObjectIsInBootImageSpace(static_field_class.Get()));
-  ArtField* int_field =
-      mirror::Class::FindField(soa.Self(), static_field_class.Get(), "intField", "I");
+  ArtField* int_field = static_field_class->FindDeclaredStaticField("intField", "I");
   ASSERT_TRUE(int_field != nullptr);
 
   Handle<mirror::Class> static_fields_test_class(hs.NewHandle(
@@ -652,7 +649,7 @@
   ASSERT_TRUE(static_fields_test_class != nullptr);
   ASSERT_FALSE(heap->ObjectIsInBootImageSpace(static_fields_test_class.Get()));
   ArtField* static_fields_test_int_field =
-      mirror::Class::FindField(soa.Self(), static_fields_test_class.Get(), "intField", "I");
+      static_fields_test_class->FindDeclaredStaticField("intField", "I");
   ASSERT_TRUE(static_fields_test_int_field != nullptr);
 
   Handle<mirror::Class> instance_fields_test_class(hs.NewHandle(
@@ -660,7 +657,7 @@
   ASSERT_TRUE(instance_fields_test_class != nullptr);
   ASSERT_FALSE(heap->ObjectIsInBootImageSpace(instance_fields_test_class.Get()));
   ArtField* instance_fields_test_int_field =
-      mirror::Class::FindField(soa.Self(), instance_fields_test_class.Get(), "intField", "I");
+      instance_fields_test_class->FindDeclaredInstanceField("intField", "I");
   ASSERT_TRUE(instance_fields_test_int_field != nullptr);
   Handle<mirror::Object> instance_fields_test_object = hs.NewHandle(
       instance_fields_test_class->Alloc(soa.Self(), heap->GetCurrentAllocator()));