commit e161a2a60c0325793f04be42a0f05228955ecfdd
author Roland Levillain <rpl@google.com> Fri Oct 03 12:45:18 2014 +0100
committer Roland Levillain <rpl@google.com> Tue Oct 14 14:44:16 2014 +0100
tree 426167496f383ec4343902f01ce0745d4dd1874d
parent 3a3fd0f8d3981691aa2331077a8fae5feee08dd1

Do not remove NullChecks & BoundsChecks in HDeadCodeElimination.

Removing a NullCheck or a BoundsCheck instruction may change
the behavior of a program.

Change-Id: Ib2c9beff0cc98c382210e7cc88b1fa9af3c61887

compiler/optimizing/dead_code_elimination.cc

diff --git a/compiler/optimizing/dead_code_elimination.cc b/compiler/optimizing/dead_code_elimination.cc
index fe2adc7..5655544 100644
--- a/compiler/optimizing/dead_code_elimination.cc
+++ b/compiler/optimizing/dead_code_elimination.cc
@@ -35,7 +35,10 @@
     for (i.Advance(); !i.Done(); i.Advance()) {
       HInstruction* inst = i.Current();
       DCHECK(!inst->IsControlFlow());
-      if (!inst->HasSideEffects() && !inst->HasUses() && !inst->IsSuspendCheck()) {
+      if (!inst->HasSideEffects()
+          && !inst->CanThrow()
+          && !inst->IsSuspendCheck()
+          && !inst->HasUses()) {
         block->RemoveInstruction(inst);
       }
     }