commit de275aaeb7bf32eeed7a091c70015517ead6e514
author Eric Holk <eholk@google.com> Mon Feb 01 22:59:11 2021 +0000
committer Eric Holk <eholk@google.com> Tue Feb 02 00:55:04 2021 +0000
tree beca367d7d047644320305cf070adcf4d811eb45
parent 480d98182efa33179f1773c791dc8f4bed62ef2b

Revert "[metrics] Add histogram statistics for reporting"

This reverts commit 3a1ca400758302f44a95ae8255ca7c012d651d73.

Reason for revert: asan failures

Test: m com.android.art
Change-Id: I26e3575add133c790ec6f2d51aac3a013216b0e0

libartbase/base/metrics/metrics_test.cc

diff --git a/libartbase/base/metrics/metrics_test.cc b/libartbase/base/metrics/metrics_test.cc
index 79684e9..f568ea0 100644
--- a/libartbase/base/metrics/metrics_test.cc
+++ b/libartbase/base/metrics/metrics_test.cc
@@ -214,7 +214,8 @@
   metrics.ReportAllMetrics(&backend);
 
   // Make sure the resulting string lists all the counters.
-#define COUNTER(name) EXPECT_NE(os.str().find(DatumName(DatumId::k##name)), std::string::npos)
+#define COUNTER(name) \
+  EXPECT_NE(os.str().find(DatumName(DatumId::k##name)), std::string::npos)
   ART_COUNTERS(COUNTER);
 #undef COUNTER
 
@@ -225,41 +226,6 @@
 #undef HISTOGRAM
 }
 
-TEST_F(MetricsTest, HistogramPercentileAndConfidenceIntervale) {
-  ArtMetrics metrics;
-
-  // Declare a backend
-  class TestBackend : public TestBackendBase {
-   public:
-    const int64_t high_value = 42000;
-    const int64_t low_value = 1;
-
-    void ReportHistogram(DatumId,
-                         int64_t minimum_value,
-                         int64_t maximum_value,
-                         const std::vector<uint32_t>& buckets) override {
-      const auto cumulative_buckets{CumulativeBuckets(buckets)};
-
-      // The 50th percentile should be below the largest value and above the highest value we added.
-      const int64_t percentile =
-          HistogramPercentile(0.50, minimum_value, maximum_value, cumulative_buckets);
-      EXPECT_LT(percentile, high_value);
-      EXPECT_GT(percentile, low_value);
-
-      // Some basic reasonableness checks for confidence intervals.
-      const auto interval =
-          HistogramConfidenceInterval(0.95, minimum_value, maximum_value, cumulative_buckets);
-      EXPECT_LT(interval.first, interval.second);
-    }
-  } backend;
-
-  // Collect some data
-  metrics.JitMethodCompileTime()->Add(backend.high_value);
-  metrics.JitMethodCompileTime()->Add(backend.low_value);
-
-  metrics.ReportAllMetrics(&backend);
-}
-
 }  // namespace metrics
 }  // namespace art