imgdiag: Do not abort for dirty pages in boot image.
Test: imgdiag_test
Bug: 77856493
Change-Id: Iec33e0dbd43105e634660f49c3d09355e601d779
diff --git a/imgdiag/imgdiag.cc b/imgdiag/imgdiag.cc
index 92953c8..f3982ec 100644
--- a/imgdiag/imgdiag.cc
+++ b/imgdiag/imgdiag.cc
@@ -1204,7 +1204,10 @@
return false;
}
- // Check that the loaded boot image is really clean.
+ // Note: the boot image is not really clean but close enough.
+ // For now, log pages found to be dirty.
+ // TODO: Rewrite imgdiag to load boot image without creating a runtime.
+ // FIXME: The following does not reliably detect dirty pages.
Runtime* runtime = Runtime::Current();
CHECK(!runtime->ShouldRelocate());
size_t total_dirty_pages = 0u;
@@ -1254,10 +1257,6 @@
total_dirty_pages += num_dirty_pages;
}
}
- if (total_dirty_pages != 0u) {
- os << "Aborting: found dirty pages in boot image that should have been clean.";
- return false;
- }
// Commit the mappings and files.
image_proc_maps_ = std::move(image_proc_maps);