commit b7d8e8cf7063fdec1cce6ebd33e33804976bd978
author Vladimir Marko <vmarko@google.com> Thu Sep 17 15:47:05 2015 +0100
committer Vladimir Marko <vmarko@google.com> Thu Sep 17 16:06:59 2015 +0100
tree 8d60856999139cf5b0b0f145f69c35a84a60716c
parent a201d5eeb0903408df925a1ed1686a55238a274c

Optimizing: Do not use range-based loop when inserting elements.

When we iterate over the elements of a container and we may
insert new elements into that container, it's wrong to use
the range-based loop.

Bug: 24133462
Change-Id: Iee35fbcf88ed3bcd6155cbeba09bd256032a16be

compiler/optimizing/nodes.h

diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h
index 33c0d88..38f4667 100644
--- a/compiler/optimizing/nodes.h
+++ b/compiler/optimizing/nodes.h
@@ -3028,7 +3028,8 @@
     : HInstruction(
           SideEffects::AllExceptGCDependency(), dex_pc),  // Assume write/read on all fields/arrays.
       number_of_arguments_(number_of_arguments),
-      inputs_(number_of_arguments + number_of_other_inputs, arena->Adapter(kArenaAllocInvokeInputs)),
+      inputs_(number_of_arguments + number_of_other_inputs,
+              arena->Adapter(kArenaAllocInvokeInputs)),
       return_type_(return_type),
       dex_method_index_(dex_method_index),
       original_invoke_type_(original_invoke_type),