commit b55ef65e55dd4d01a9bdf315c09c090b73f7c19a
author Alex Light <allight@google.com> Thu Sep 26 15:23:28 2019 -0700
committer Treehugger Robot <treehugger-gerrit@google.com> Fri Sep 27 00:50:16 2019 +0000
tree 04b9723f47ab2570a4eb825b0377c731216ea2c6
parent b096c918a5f20abb3426f1693435e230f2e07445

Improve VLOG_STREAM

Previously VLOG_STREAM would always print even if the module was
turned off. This changes VLOG_STREAM to not print when the module is
off. Like with LOG_STREAM the stream is consumed even if it's not
printed.

Also updated some ti_heap.cc logs to use LOG_STREAM.

Test: ./test/run-test --host --dev 1981
Test: ./test/run-test --host --dev --runtime-option -verbose:plugin 1981
Test: ./test.py --host
Change-Id: If709474918b3e67749647fae5accb0ce98ea3a59

openjdkjvmti/ti_heap.cc

diff --git a/openjdkjvmti/ti_heap.cc b/openjdkjvmti/ti_heap.cc
index f14fbaf..bbb2ced 100644
--- a/openjdkjvmti/ti_heap.cc
+++ b/openjdkjvmti/ti_heap.cc
@@ -1707,11 +1707,11 @@
             const art::JavaFrameRootInfo& jfri =
                 art::down_cast<const art::JavaFrameRootInfo&>(info);
             if (jfri.GetVReg() == art::JavaFrameRootInfo::kMethodDeclaringClass) {
-              info.Describe(LOG_STREAM(INFO) << "Not changing declaring-class during stack walk. "
-                                                "Found obsolete java frame id ");
+              info.Describe(VLOG_STREAM(plugin) << "Not changing declaring-class during stack"
+                                                << " walk. Found obsolete java frame id ");
               continue;
             } else {
-              info.Describe(LOG_STREAM(INFO) << "Found java frame id ");
+              info.Describe(VLOG_STREAM(plugin) << "Found java frame id ");
               threads_with_roots_.insert(info.GetThreadId());
             }
           }
@@ -1733,11 +1733,11 @@
             const art::JavaFrameRootInfo& jfri =
                 art::down_cast<const art::JavaFrameRootInfo&>(info);
             if (jfri.GetVReg() == art::JavaFrameRootInfo::kMethodDeclaringClass) {
-              info.Describe(LOG_STREAM(INFO) << "Not changing declaring-class during stack walk. "
-                                                "Found obsolete java frame id ");
+              info.Describe(VLOG_STREAM(plugin) << "Not changing declaring-class during stack"
+                                                << " walk. Found obsolete java frame id ");
               continue;
             } else {
-              info.Describe(LOG_STREAM(INFO) << "Found java frame id ");
+              info.Describe(VLOG_STREAM(plugin) << "Found java frame id ");
               threads_with_roots_.insert(info.GetThreadId());
             }
           }