| commit | 6e93863c09dd96fc6b874d5a33144ff65b950956 | [log] [tgz] |
|---|---|---|
| author | Jiakai Zhang <jiakaiz@google.com> | Thu Jun 01 19:03:42 2023 +0100 |
| committer | Cherrypicker Worker <android-build-cherrypicker-worker@google.com> | Fri Jan 26 16:30:59 2024 +0000 |
| tree | 203088324320d312909f5176ed8bf7f30a9aa7d5 | |
| parent | 828160aaf192ab7c60d0efd2811fb51c59b14efb [diff] |
Stop checking the PROT_EXEC bit in dexpreopt test. When the test was written, odex files didn't get unmapped if the runtime rejects them in some cases (e.g., CLC mismatch). Therefore, we needed to check the PROT_EXEC flag to ensure that they are valid. That's not the case anymore. Today, app images do get unmapped if rejected. The check on the PROT_EXEC flag has a drawback: if an odex file is generated with the "verify" compiler filter, it won't contain any code and therefore won't be mapped with PROT_EXEC. In this case, the test will report false positives. Bug: 267540738 Test: atest art_standalone_dexpreopt_tests (cherry picked from https://android-review.googlesource.com/q/commit:83d429403f6eebdeb3c4bc84a652dad632fa15e6) Merged-In: I6bcdcb7ccc9c1fff1773b362eaff3fc44c40d46b Change-Id: I6bcdcb7ccc9c1fff1773b362eaff3fc44c40d46b