runtime/jit: inclusive language fixes
Based on:
https://source.android.com/setup/contribute/respectful-code
Bug: 161896447
Bug: 161850439
Bug: 161336379
Test: m (comment updates only).
Change-Id: Ibfb4b0c71ef2fae076a6b11dfabe07137f00a7a5
diff --git a/runtime/jit/jit.cc b/runtime/jit/jit.cc
index 8aae7bf..5684020 100644
--- a/runtime/jit/jit.cc
+++ b/runtime/jit/jit.cc
@@ -104,7 +104,7 @@
jit_options->thread_pool_pthread_priority_ =
options.GetOrDefault(RuntimeArgumentMap::JITPoolThreadPthreadPriority);
- // Set default compile threshold to aide with sanity checking defaults.
+ // Set default compile threshold to aid with checking defaults.
jit_options->compile_threshold_ =
kIsDebugBuild
? (Jit::kSlowMode
@@ -115,7 +115,7 @@
// When not running in slow-mode, thresholds are quantized to kJitSamplesbatchsize.
const uint32_t kJitThresholdStep = Jit::kSlowMode ? 1u : kJitSamplesBatchSize;
- // Set default warm-up threshold to aide with sanity checking defaults.
+ // Set default warm-up threshold to aid with checking defaults.
jit_options->warmup_threshold_ =
kIsDebugBuild ? (Jit::kSlowMode
? kJitSlowStressDefaultWarmUpThreshold
@@ -1558,7 +1558,7 @@
self,
new JitCompileTask(method,
JitCompileTask::TaskKind::kAllocateProfile,
- CompilationKind::kOptimized)); // Dummy compilation kind.
+ CompilationKind::kOptimized)); // Arbitrary compilation kind.
}
}
}
diff --git a/runtime/jit/jit_code_cache.cc b/runtime/jit/jit_code_cache.cc
index 373d93c..59f1576 100644
--- a/runtime/jit/jit_code_cache.cc
+++ b/runtime/jit/jit_code_cache.cc
@@ -1070,7 +1070,7 @@
if (kIsDebugBuild) {
// The stack walking code queries the side instrumentation stack if it
// sees an instrumentation exit pc, so the JIT code of methods in that stack
- // must have been seen. We sanity check this below.
+ // must have been seen. We check this below.
for (const auto& it : *thread->GetInstrumentationStack()) {
// The 'method_' in InstrumentationStackFrame is the one that has return_pc_ in
// its stack frame, it is not the method owning return_pc_. We just pass null to
@@ -1389,7 +1389,7 @@
}
}
} else if (kIsDebugBuild) {
- // Sanity check that the profiling infos do not have a dangling entry point.
+ // Check that the profiling infos do not have a dangling entry point.
for (ProfilingInfo* info : profiling_infos_) {
DCHECK(!Runtime::Current()->IsZygote());
const void* entry_point = info->GetSavedEntryPoint();
diff --git a/runtime/jit/jit_code_cache.h b/runtime/jit/jit_code_cache.h
index d055ed3..12a21a3 100644
--- a/runtime/jit/jit_code_cache.h
+++ b/runtime/jit/jit_code_cache.h
@@ -287,9 +287,9 @@
REQUIRES(!Locks::jit_lock_)
REQUIRES_SHARED(Locks::mutator_lock_);
- // Given the 'pc', try to find the JIT compiled code associated with it.
- // Return null if 'pc' is not in the code cache. 'method' is passed for
- // sanity check.
+ // Given the 'pc', try to find the JIT compiled code associated with it. 'method' may be null
+ // when LookupMethodHeader is called from MarkCodeClosure::Run() in debug builds. Return null
+ // if 'pc' is not in the code cache.
OatQuickMethodHeader* LookupMethodHeader(uintptr_t pc, ArtMethod* method)
REQUIRES(!Locks::jit_lock_)
REQUIRES_SHARED(Locks::mutator_lock_);