commit 7d95565c84d91ae5dcec4b89728ada208633de0c
author Sebastien Hertz <shertz@google.com> Wed Oct 22 10:57:10 2014 +0200
committer Sebastien Hertz <shertz@google.com> Wed Dec 17 09:38:28 2014 +0100
tree 3d45e97f3ca520a07c5005974b092e10fee0a433
parent f610c0597e001cb1043aa4074afe25ae79a800e3

Cleanup JDWP event matching

* Use std::vector for the event match list.
* Make event reporting methods void since result is never used.
* Use nullptr keyword instead of NULL.

Change-Id: Icd6f47e46cefc2cc63325df00037cd4b6a475259

runtime/debugger.cc

diff --git a/runtime/debugger.cc b/runtime/debugger.cc
index 7cc52c3..a3a043f 100644
--- a/runtime/debugger.cc
+++ b/runtime/debugger.cc
@@ -669,9 +669,7 @@
   // This may cause us to suspend all threads.
   if (gJdwpState->IsActive()) {
     ScopedObjectAccess soa(Thread::Current());
-    if (!gJdwpState->PostVMStart()) {
-      LOG(WARNING) << "Failed to post 'start' message to debugger";
-    }
+    gJdwpState->PostVMStart();
   }
 }
 
@@ -2569,7 +2567,7 @@
     VLOG(jdwp) << "    --> slot " << slot << " " << reqSigByte;
 
     size_t width = Dbg::GetTagWidth(reqSigByte);
-    uint8_t* ptr = expandBufAddSpace(pReply, width+1);
+    uint8_t* ptr = expandBufAddSpace(pReply, width + 1);
     JDWP::JdwpError error = Dbg::GetLocalValue(visitor, soa, slot, reqSigByte, ptr, width);
     if (error != JDWP::ERR_NONE) {
       return error;