Prevent subprocesses from accessing FDs opened in other threads.
Unlike installd, artd is multi-threaded. When we fork & exec, the
subprocess gets FDs opened in all threads. This is unexpected. For
example, profman gets FDs opened for dex2oat. This CL prevents this by
closing other FDs before we exec.
Bug: 262230400
Test: m test-art-host-gtest-art_artd_tests
Test: m test-art-host-gtest-art_libarttools_tests
Test: atest ArtGtestsTargetChroot:ArtExecTest
Test: -
1. adb shell setprop pm.dexopt.bg-dexopt.concurrency 4
2. adb shell pm art optimize-packages bg-dexopt
3. No longer see SELinux complaining that profman is trying to read
some files opened for dex2oat.
Ignore-AOSP-First: ART Services.
Change-Id: Ia8068d804294debe0de6c947f3878da4dbf8c8ca
diff --git a/artd/testing.h b/artd/testing.h
new file mode 100644
index 0000000..df01a9a
--- /dev/null
+++ b/artd/testing.h
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2022 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef ART_ARTD_TESTING_H_
+#define ART_ARTD_TESTING_H_
+
+// Returns the value of the given `android::base::Result`, or reports the error as a gMock matcher
+// mismatch. This is only to be used in a gMock matcher.
+#define OR_MISMATCH(expr) \
+ ({ \
+ decltype(expr)&& tmp__ = (expr); \
+ if (!tmp__.ok()) { \
+ *result_listener << tmp__.error().message(); \
+ return false; \
+ } \
+ std::move(tmp__).value(); \
+ })
+
+// Returns the value of the given `android::base::Result`, or fails the GoogleTest.
+#define OR_FAIL(expr) \
+ ({ \
+ decltype(expr)&& tmp__ = (expr); \
+ ASSERT_TRUE(tmp__.ok()) << tmp__.error().message(); \
+ std::move(tmp__).value(); \
+ })
+
+#endif // ART_ARTD_TESTING_H_