commit 5573c37e795668eca81a8488078f798d977685c3
author Igor Murashkin <iam@google.com> Thu Nov 16 13:34:30 2017 -0800
committer Igor Murashkin <iam@google.com> Thu Nov 16 14:42:49 2017 -0800
tree 5e7675d6c1ca9ed1c31834e52282bfb9f73dc2a4
parent 1598a77ca3559c8a59902f26ee887504b8159859

cpplint: Remove many unnecessary NOLINT

Now that we updated to upstream cpplint, a lot of these NOLINTs are no
longer necessary.

Bug: 68951293
Change-Id: If8ed5ffe89727f313f907a214b6d8fd2a2eddbad

compiler/utils/intrusive_forward_list_test.cc

diff --git a/compiler/utils/intrusive_forward_list_test.cc b/compiler/utils/intrusive_forward_list_test.cc
index 939676c..e97c304 100644
--- a/compiler/utils/intrusive_forward_list_test.cc
+++ b/compiler/utils/intrusive_forward_list_test.cc
@@ -574,11 +574,11 @@
   ref.remove(4);
   ifl.remove(4);
   ASSERT_LISTS_EQUAL(ref, ifl);
-  auto odd = [](ValueType value) { return (value.value & 1) != 0; };  // NOLINT(readability/braces)
+  auto odd = [](ValueType value) { return (value.value & 1) != 0; };
   ref.remove_if(odd);
   ifl.remove_if(odd);
   ASSERT_LISTS_EQUAL(ref, ifl);
-  auto all = [](ValueType value ATTRIBUTE_UNUSED) { return true; };  // NOLINT(readability/braces)
+  auto all = [](ValueType value ATTRIBUTE_UNUSED) { return true; };
   ref.remove_if(all);
   ifl.remove_if(all);
   ASSERT_LISTS_EQUAL(ref, ifl);
@@ -721,7 +721,7 @@
   ListType ifl(storage.begin(), storage.end());
   ASSERT_LISTS_EQUAL(ref, ifl);
 
-  auto add1 = [](const ValueType& value) { return value.value + 1; };  // NOLINT [readability/braces]
+  auto add1 = [](const ValueType& value) { return value.value + 1; };
   std::transform(ref.begin(), ref.end(), ref.begin(), add1);
   std::transform(ifl.begin(), ifl.end(), ifl.begin(), add1);
   ASSERT_LISTS_EQUAL(ref, ifl);

compiler/utils/swap_space.h

diff --git a/compiler/utils/swap_space.h b/compiler/utils/swap_space.h
index 08e243b..2280f8b 100644
--- a/compiler/utils/swap_space.h
+++ b/compiler/utils/swap_space.h
@@ -124,7 +124,7 @@
   explicit SwapAllocator(SwapSpace* swap_space) : swap_space_(swap_space) {}
 
   template <typename U>
-  SwapAllocator(const SwapAllocator<U>& other)  // NOLINT, implicit
+  SwapAllocator(const SwapAllocator<U>& other)
       : swap_space_(other.swap_space_) {}
 
   SwapAllocator(const SwapAllocator& other) = default;
@@ -160,7 +160,7 @@
   explicit SwapAllocator(SwapSpace* swap_space) : swap_space_(swap_space) {}
 
   template <typename U>
-  SwapAllocator(const SwapAllocator<U>& other)  // NOLINT, implicit
+  SwapAllocator(const SwapAllocator<U>& other)
       : swap_space_(other.swap_space_) {}
 
   SwapAllocator(const SwapAllocator& other) = default;

compiler/utils/x86/assembler_x86_test.cc

diff --git a/compiler/utils/x86/assembler_x86_test.cc b/compiler/utils/x86/assembler_x86_test.cc
index e232add..36c5c3c 100644
--- a/compiler/utils/x86/assembler_x86_test.cc
+++ b/compiler/utils/x86/assembler_x86_test.cc
@@ -90,7 +90,7 @@
     }
     if (registers_.size() == 0) {
       registers_.insert(end(registers_),
-                        {  // NOLINT(whitespace/braces)
+                        {
                           new x86::Register(x86::EAX),
                           new x86::Register(x86::EBX),
                           new x86::Register(x86::ECX),
@@ -104,7 +104,7 @@
 
     if (fp_registers_.size() == 0) {
       fp_registers_.insert(end(fp_registers_),
-                           {  // NOLINT(whitespace/braces)
+                           {
                              new x86::XmmRegister(x86::XMM0),
                              new x86::XmmRegister(x86::XMM1),
                              new x86::XmmRegister(x86::XMM2),