commit 289da82ae82438ab3aed1898c82fd87c16846e74
author Elliott Hughes <enh@google.com> Tue Aug 16 10:11:20 2011 -0700
committer Elliott Hughes <enh@google.com> Tue Aug 16 10:35:27 2011 -0700
tree 31cff59beae91556fb85aa2e11da1697b6feea67
parent 04b63fd60de0d9e6f07763511a1a9622accfeed7

Add bounds checking to our internal array get/set methods.

Change-Id: Ia570615e6b4ea81d796b6bf720444c62830a4f89

src/jni_internal_test.cc

diff --git a/src/jni_internal_test.cc b/src/jni_internal_test.cc
index e5ba913..9394ff6 100644
--- a/src/jni_internal_test.cc
+++ b/src/jni_internal_test.cc
@@ -92,7 +92,8 @@
 
   // TODO: check non-NULL initial elements.
 
-  jclass c = env_->FindClass("[Ljava.lang.String;");
+  jclass c = env_->FindClass("[Ljava/lang/String;");
+  ASSERT_TRUE(c != NULL);
 
   EXPECT_TRUE(env_->NewObjectArray(0, c, NULL) != NULL);
 
@@ -106,6 +107,18 @@
   // TODO: check some non-ASCII strings.
 }
 
+TEST_F(JniInternalTest, SetObjectArrayElement) {
+  jclass c = env_->FindClass("[Ljava/lang/Object;");
+  ASSERT_TRUE(c != NULL);
+
+  jobjectArray array = env_->NewObjectArray(1, c, NULL);
+  EXPECT_TRUE(array != NULL);
+  env_->SetObjectArrayElement(array, 0, c);
+  // TODO: check reading value back
+  // TODO: check IndexOutOfBoundsExceptions thrown for bad indexes.
+  // TODO: check ArrayStoreException thrown for bad types.
+}
+
 bool EnsureInvokeStub(Method* method);
 
 byte* AllocateCode(void* code, size_t length) {