commit 256c94b568f35f8f23feaaf9ea0d64ed1edab1d4
author Nicolas Geoffray <ngeoffray@google.com> Mon Apr 29 10:55:09 2019 +0100
committer Nicolas Geoffray <ngeoffray@google.com> Tue Apr 30 09:49:17 2019 +0000
tree 1f03dfa6f05ee6d4fc2c0a534ff8b5d5031c80cc
parent 7711c35fa603b86d520991c4e97ca297add81881

Update induction ranges in superblock cloner.

Because loop unrolling is part of a general loop optimization pass,
it needs to update induction ranges as it will invalidate its
instruction cache with new instructions.

Bug: 131174583
Test: 696-loop
Change-Id: Id3628efe316b58f69abbd9ebd43e891a8e42529f

compiler/optimizing/superblock_cloner_test.cc

diff --git a/compiler/optimizing/superblock_cloner_test.cc b/compiler/optimizing/superblock_cloner_test.cc
index 31114b6..aa19de6 100644
--- a/compiler/optimizing/superblock_cloner_test.cc
+++ b/compiler/optimizing/superblock_cloner_test.cc
@@ -162,7 +162,8 @@
   SuperblockCloner cloner(graph_,
                           &orig_bb_set,
                           &bb_map,
-                          &hir_map);
+                          &hir_map,
+                          /* induction_range= */ nullptr);
   EXPECT_TRUE(cloner.IsSubgraphClonable());
 
   cloner.CloneBasicBlocks();
@@ -239,8 +240,9 @@
 
   SuperblockCloner cloner(graph_,
                           &orig_bb_set,
-                          nullptr,
-                          nullptr);
+                          /* bb_map= */ nullptr,
+                          /* hir_map= */ nullptr,
+                          /* induction_range= */ nullptr);
   EXPECT_TRUE(cloner.IsSubgraphClonable());
 
   cloner.FindAndSetLocalAreaForAdjustments();
@@ -321,7 +323,7 @@
       std::less<HInstruction*>(), graph_->GetAllocator()->Adapter(kArenaAllocSuperblockCloner));
 
   HLoopInformation* loop_info = header->GetLoopInformation();
-  PeelUnrollHelper helper(loop_info, &bb_map, &hir_map);
+  PeelUnrollHelper helper(loop_info, &bb_map, &hir_map, /* induction_range= */ nullptr);
   EXPECT_TRUE(helper.IsLoopClonable());
   HBasicBlock* new_header = helper.DoPeeling();
   HLoopInformation* new_loop_info = new_header->GetLoopInformation();
@@ -380,7 +382,7 @@
       std::less<HInstruction*>(), graph_->GetAllocator()->Adapter(kArenaAllocSuperblockCloner));
 
   HLoopInformation* loop_info = header->GetLoopInformation();
-  PeelUnrollHelper helper(loop_info, &bb_map, &hir_map);
+  PeelUnrollHelper helper(loop_info, &bb_map, &hir_map, /* induction_range= */ nullptr);
   EXPECT_TRUE(helper.IsLoopClonable());
   HBasicBlock* new_header = helper.DoUnrolling();
 
@@ -435,7 +437,7 @@
   EXPECT_TRUE(CheckGraph());
 
   HLoopInformation* loop_info = header->GetLoopInformation();
-  PeelUnrollSimpleHelper helper(loop_info);
+  PeelUnrollSimpleHelper helper(loop_info, /* induction_range= */ nullptr);
   HBasicBlock* new_header = helper.DoPeeling();
   EXPECT_EQ(header, new_header);
 
@@ -484,7 +486,7 @@
 
   // Check nested loops structure.
   CheckLoopStructureForLoopPeelingNested(loop1_header, loop2_header, loop3_header);
-  PeelUnrollSimpleHelper helper(loop1_header->GetLoopInformation());
+  PeelUnrollSimpleHelper helper(loop1_header->GetLoopInformation(), /* induction_range= */ nullptr);
   helper.DoPeeling();
   // Check that nested loops structure has not changed after the transformation.
   CheckLoopStructureForLoopPeelingNested(loop1_header, loop2_header, loop3_header);
@@ -530,7 +532,7 @@
   graph_->BuildDominatorTree();
   EXPECT_TRUE(CheckGraph());
 
-  PeelUnrollSimpleHelper helper(loop3_header->GetLoopInformation());
+  PeelUnrollSimpleHelper helper(loop3_header->GetLoopInformation(), /* induction_range= */ nullptr);
   helper.DoPeeling();
   HLoopInformation* loop1 = loop1_header->GetLoopInformation();
   HLoopInformation* loop2 = loop2_header->GetLoopInformation();
@@ -596,7 +598,7 @@
   HBasicBlock* loop3_long_exit = loop3_extra_if_block->GetSuccessors()[0];
   EXPECT_TRUE(loop1_header->GetLoopInformation()->Contains(*loop3_long_exit));
 
-  PeelUnrollSimpleHelper helper(loop3_header->GetLoopInformation());
+  PeelUnrollSimpleHelper helper(loop3_header->GetLoopInformation(), /* induction_range= */ nullptr);
   helper.DoPeeling();
 
   HLoopInformation* loop1 = loop1_header->GetLoopInformation();
@@ -653,7 +655,8 @@
   SuperblockCloner cloner(graph_,
                           &orig_bb_set,
                           &bb_map,
-                          &hir_map);
+                          &hir_map,
+                          /* induction_range= */ nullptr);
   cloner.SetSuccessorRemappingInfo(&remap_orig_internal, &remap_copy_internal, &remap_incoming);
 
   EXPECT_FALSE(cloner.IsFastCase());