commit 12abcbd950bd0ff4528e2e0d27ca5e881c7b0467
author Nicolas Geoffray <ngeoffray@google.com> Mon Jun 06 15:51:58 2016 +0000
committer Nicolas Geoffray <ngeoffray@google.com> Mon Jun 06 15:51:58 2016 +0000
tree 2788e5aec7b022694f7e7d41c1e40c205e46596e
parent 808067335b228d7b50ad84123d3c8ecb7aeeb200

Revert "Fix ArtMethod::GetInvokeType for static methods on interfaces."

bug:29089267
bug:27521545

Fails some DHECKs.

This reverts commit 808067335b228d7b50ad84123d3c8ecb7aeeb200.

Change-Id: I0e768ce85be593e3f50fd02abc29aa34f2be3562

compiler/optimizing/optimizing_compiler.cc

diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc
index 0e0a30b..37197af 100644
--- a/compiler/optimizing/optimizing_compiler.cc
+++ b/compiler/optimizing/optimizing_compiler.cc
@@ -321,7 +321,6 @@
                             jobject class_loader,
                             const DexFile& dex_file,
                             Handle<mirror::DexCache> dex_cache,
-                            ArtMethod* method,
                             bool osr) const;
 
   std::unique_ptr<OptimizingCompilerStats> compilation_stats_;
@@ -615,7 +614,6 @@
                                               jobject class_loader,
                                               const DexFile& dex_file,
                                               Handle<mirror::DexCache> dex_cache,
-                                              ArtMethod* method,
                                               bool osr) const {
   MaybeRecordStat(MethodCompilationStat::kAttemptCompilation);
   CompilerDriver* compiler_driver = GetCompilerDriver();
@@ -681,21 +679,18 @@
       osr);
 
   const uint8_t* interpreter_metadata = nullptr;
-  if (method == nullptr) {
+  {
     ScopedObjectAccess soa(Thread::Current());
     StackHandleScope<1> hs(soa.Self());
     Handle<mirror::ClassLoader> loader(hs.NewHandle(
         soa.Decode<mirror::ClassLoader*>(class_loader)));
-    method = compiler_driver->ResolveMethod(
+    ArtMethod* art_method = compiler_driver->ResolveMethod(
         soa, dex_cache, loader, &dex_compilation_unit, method_idx, invoke_type);
-  }
-  // For AOT compilation, we may not get a method, for example if its class is erroneous.
-  // JIT should always have a method.
-  DCHECK(Runtime::Current()->IsAotCompiler() || method != nullptr);
-  if (method != nullptr) {
-    graph->SetArtMethod(method);
-    ScopedObjectAccess soa(Thread::Current());
-    interpreter_metadata = method->GetQuickenedInfo();
+    // We may not get a method, for example if its class is erroneous.
+    if (art_method != nullptr) {
+      graph->SetArtMethod(art_method);
+      interpreter_metadata = art_method->GetQuickenedInfo();
+    }
   }
 
   std::unique_ptr<CodeGenerator> codegen(
@@ -803,7 +798,6 @@
                    jclass_loader,
                    dex_file,
                    dex_cache,
-                   nullptr,
                    /* osr */ false));
     if (codegen.get() != nullptr) {
       MaybeRecordStat(MethodCompilationStat::kCompiled);
@@ -890,7 +884,6 @@
                    jclass_loader,
                    *dex_file,
                    dex_cache,
-                   method,
                    osr));
     if (codegen.get() == nullptr) {
       return false;