tree 6c58e10e556a04afc88d25710934b04b12244cb1
parent 59399abce0223e74af00193436e39e109d98dacb
author Vladimir Marko <vmarko@google.com> 1462292270 +0100
committer Vladimir Marko <vmarko@google.com> 1462458278 +0100

Fix ProtoId ordering check in DexFileVerifier.

The code previously checked for kNoDexIndex16 as the type
list terminator. This is incorrect as we should not actually
see the kNoDexIndex16 in type lists in supported dex files.

To make sure that we don't see kNoDexIndex16, check the size
of the arrays with documented limits, i.e. type-ids and
proto-ids, see dex_file.h. In the ProtoId ordering check,
DCHECK() that we don't encounter kNoDexIndex16 and verify
that the previous list is not longer if the current list's
elements match.

Bug: 28580925
Change-Id: I7b17ce54b0047d97e13be88377676b1b7c713ae1