tree 0cc8a3a786a1309d5fdaddee5c3d52bf9ecf778b
parent c0fc0c76886d7f5531ce89a16c6b87262eff31f1
author Christian Brauner <christian@brauner.io> 1555582719 +0200
committer SamarV-121 <samarvispute121@pm.me> 1661060786 +0530
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEEeLjQnpaA0nK4ePoG6k72I5JuL64FAmMBxrIACgkQ6k72I5Ju
 L64ckQv/bGEQNPrmCX1PglCFrKVM8rTjvaDSCI9TPvxgu5zZcRsNrQ1DsG079tKW
 jtt/5s9RjknlfzjypVR91hMUKtSwhee6KlDdT1jDgboj+lzIovcM6IYWUaEipLaY
 UrzPdzZZBAWHNyCZJ/FHsgqTiSE+iBWpwyWmxNPSP47nFICqjchbtj03O4XLKMDx
 WyJQdF+YMnjKJSiWo1n4mpWUniTaeq8UWMPSLQ3zYWbrMjvSp/7naiAEhIM5eFti
 P1lhqeekJxIQs7p66U87Wpe/EzWH+wb5lnwAOl1A86u4UbIyqpkEwX6YX9UcSwYj
 QnUuZCu1QFsNmj5c53RiiMWMlI4LrST0NLn6bBcm/TRhXmUcagRTjVyorF4Swc6y
 RU58FGtxZcBQ+a06WOe6nqpuwfxtVuVv0qbX92I2cf4yTmb7hqwwb413CZ8LtRQT
 WcZYtBSDY6ZRFWaLog3twsJLU1x3yER0gI1OULbxLz79OAWKJPWYw4ot84xCMCdM
 Z3XTbwNM
 =mbPI
 -----END PGP SIGNATURE-----

UPSTREAM: signal: use fdget() since we don't allow O_PATH

As stated in the original commit for pidfd_send_signal() we don't allow
to signal processes through O_PATH file descriptors since it is
semantically equivalent to a write on the pidfd.

We already correctly error out right now and return EBADF if an O_PATH
fd is passed.  This is because we use file->f_op to detect whether a
pidfd is passed and O_PATH fds have their file->f_op set to empty_fops
in do_dentry_open() and thus fail the test.

Thus, there is no regression.  It's just semantically correct to use
fdget() and return an error right from there instead of taking a
reference and returning an error later.

Signed-off-by: Christian Brauner <christian@brauner.io>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jann Horn <jann@thejh.net>
Cc: David Howells <dhowells@redhat.com>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Andy Lutomirsky <luto@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Aleksa Sarai <cyphar@cyphar.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

(cherry picked from commit 738a7832d21e3d911fcddab98ce260b79010b461)

Bug: 135608568
Test: test program using syscall(__NR_pidfd_send_signal,..) to send SIGKILL
Change-Id: Id52eaadf9da371fb2d9caae4df49627760de7229
Signed-off-by: Suren Baghdasaryan <surenb@google.com>