tree a0a54691f472b5a78d4ac564a9a020881580506c
parent f751d9a9f3d6c01908cf9bc9d966a35ecc1a2f64
author Daniel Thompson <daniel.thompson@linaro.org> 1713967415 +0100
committer Vegard Nossum <vegard.nossum@oracle.com> 1721068223 +0000

kdb: Use format-strings rather than '\0' injection in kdb_read()

commit 09b35989421dfd5573f0b4683c7700a7483c71f9 upstream.

Currently when kdb_read() needs to reposition the cursor it uses copy and
paste code that works by injecting an '\0' at the cursor position before
delivering a carriage-return and reprinting the line (which stops at the
'\0').

Tidy up the code by hoisting the copy and paste code into an appropriately
named function. Additionally let's replace the '\0' injection with a
proper field width parameter so that the string will be abridged during
formatting instead.

Cc: stable@vger.kernel.org # Not a bug fix but it is needed for later bug fixes
Tested-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240424-kgdb_read_refactor-v3-2-f236dbe9828d@linaro.org
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 4edfbbaca46491b06af14e49dcb79ac661d0bbdc)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>