[SERIAL] kernel console should send CRLF not LFCR
Glen Turner reported that writing LFCR rather than the more
traditional CRLF causes issues with some terminals.
Since this aflicts many serial drivers, extract the common code
to a library function (uart_console_write) and arrange for each
driver to supply a "putchar" function.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 61dd17d..928e6cf 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -603,15 +603,14 @@
udelay(1);
/* Write all the chars */
- for ( i=0 ; i<count ; i++ ) {
-
+ for (i = 0; i < count; i++, s++) {
+ /* Line return handling */
+ if (*s == '\n')
+ out_8(&psc->mpc52xx_psc_buffer_8, '\r');
+
/* Send the char */
out_8(&psc->mpc52xx_psc_buffer_8, *s);
- /* Line return handling */
- if ( *s++ == '\n' )
- out_8(&psc->mpc52xx_psc_buffer_8, '\r');
-
/* Wait the TX buffer to be empty */
j = 20000; /* Maximum wait */
while (!(in_be16(&psc->mpc52xx_psc_status) &