tree 1ba5d3350ce4969fd8134786aec41e9a9c357746
parent 201f3d45deb9bcf1046483d72642d8457976c7a9
author Daniel Thompson <daniel.thompson@linaro.org> 1713967418 +0100
committer Vegard Nossum <vegard.nossum@oracle.com> 1721068224 +0000

kdb: Use format-specifiers rather than memset() for padding in kdb_read()

commit c9b51ddb66b1d96e4d364c088da0f1dfb004c574 upstream.

Currently when the current line should be removed from the display
kdb_read() uses memset() to fill a temporary buffer with spaces.
The problem is not that this could be trivially implemented using a
format string rather than open coding it. The real problem is that
it is possible, on systems with a long kdb_prompt_str, to write past
the end of the tmpbuffer.

Happily, as mentioned above, this can be trivially implemented using a
format string. Make it so!

Cc: stable@vger.kernel.org
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20240424-kgdb_read_refactor-v3-5-f236dbe9828d@linaro.org
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 2467f3f182eb35627534effd4956fceb2504c127)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>