tree 0e8ee38bdfa8aa470be25d93cc68b2665f1addb6
parent 92b446b2b7dfe86c8955bf914789754b2d44ec81
author Baokun Li <libaokun1@huawei.com> 1688123302 +0800
committer Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> 1713263432 +0000

quota: simplify drop_dquot_ref()

[ Upstream commit 7bce48f0fec602b3b6c335963b26d9eefa417788 ]

As Honza said, remove_inode_dquot_ref() currently does not release the
last dquot reference but instead adds the dquot to tofree_head list. This
is because dqput() can sleep while dropping of the last dquot reference
(writing back the dquot and calling ->release_dquot()) and that must not
happen under dq_list_lock. Now that dqput() queues the final dquot cleanup
into a workqueue, remove_inode_dquot_ref() can call dqput() unconditionally
and we can significantly simplify it.

Here we open code the simplified code of remove_inode_dquot_ref() into
remove_dquot_ref() and remove the function put_dquot_list() which is no
longer used.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Message-Id: <20230630110822.3881712-6-libaokun1@huawei.com>
Stable-dep-of: 179b8c97ebf6 ("quota: Fix rcu annotations of inode dquot pointers")
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 248699a705f31211c0d7cc9e0d79cbbabbc9c791)
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>