tree e635750c82fe5e60db3c6cebb99ca8b61fad0661
parent b2d1965dcea148100ffc4e7199470bf5fad13871
author Takashi Iwai <tiwai@suse.de> 1417713919 +0100
committer Mimi Zohar <zohar@linux.vnet.ibm.com> 1417920636 -0500

KEYS: Fix stale key registration at error path

When loading encrypted-keys module, if the last check of
aes_get_sizes() in init_encrypted() fails, the driver just returns an
error without unregistering its key type.  This results in the stale
entry in the list.  In addition to memory leaks, this leads to a kernel
crash when registering a new key type later.

This patch fixes the problem by swapping the calls of aes_get_sizes()
and register_key_type(), and releasing resources properly at the error
paths.

Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=908163
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>