tree 188f6e37491581cc85e404671e4daa7184fcd56a
parent 336db5bbf15c2e86555a7b369f8faa7b3d4abe0f
author Guanrui Huang <guanrui.huang@linux.alibaba.com> 1713420652 +0800
committer Vegard Nossum <vegard.nossum@oracle.com> 1717160248 +0000

irqchip/gic-v3-its: Prevent double free on error

commit c26591afd33adce296c022e3480dea4282b7ef91 upstream.

The error handling path in its_vpe_irq_domain_alloc() causes a double free
when its_vpe_init() fails after successfully allocating at least one
interrupt. This happens because its_vpe_irq_domain_free() frees the
interrupts along with the area bitmap and the vprop_page and
its_vpe_irq_domain_alloc() subsequently frees the area bitmap and the
vprop_page again.

Fix this by unconditionally invoking its_vpe_irq_domain_free() which
handles all cases correctly and by removing the bitmap/vprop_page freeing
from its_vpe_irq_domain_alloc().

[ tglx: Massaged change log ]

Fixes: 7d75bbb4bc1a ("irqchip/gic-v3-its: Add VPE irq domain allocation/teardown")
Signed-off-by: Guanrui Huang <guanrui.huang@linux.alibaba.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240418061053.96803-2-guanrui.huang@linux.alibaba.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit f5417ff561b8ac9a7e53c747b8627a7ab58378ae)
[Vegard: fix conflict due to missing commit
 38dd7c494cf604879e187e9b56690d25f876cf69 ("irqchip/gic-v3-its: Drop
 chunk allocation compatibility").]
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>