tree 0cac29f82066b61a5922bda1b3cae147712f3fd1
parent 68e8ffca8bcb4619d8a20a711cf51a3464530790
author Alan Stern <stern@rowland.harvard.edu> 1710366221 -0400
committer Vegard Nossum <vegard.nossum@oracle.com> 1717158640 +0000

fs: sysfs: Fix reference leak in sysfs_break_active_protection()

commit a90bca2228c0646fc29a72689d308e5fe03e6d78 upstream.

The sysfs_break_active_protection() routine has an obvious reference
leak in its error path.  If the call to kernfs_find_and_get() fails then
kn will be NULL, so the companion sysfs_unbreak_active_protection()
routine won't get called (and would only cause an access violation by
trying to dereference kn->parent if it was called).  As a result, the
reference to kobj acquired at the start of the function will never be
released.

Fix the leak by adding an explicit kobject_put() call when kn is NULL.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Fixes: 2afc9166f79b ("scsi: sysfs: Introduce sysfs_{un,}break_active_protection()")
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: stable@vger.kernel.org
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/8a4d3f0f-c5e3-4b70-a188-0ca433f9e6f9@rowland.harvard.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit f28bba37fe244889b81bb5c508d3f6e5c6e342c5)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>