tree f3f3d41a94da29c390f5a0df0136bbcf62c0ee73
parent 273d17ed35348d5e6cabe23d9170c876f95f3946
author Wei Fang <wei.fang@nxp.com> 1716259080 +0800
committer Vegard Nossum <vegard.nossum@oracle.com> 1721065471 +0000

net: fec: avoid lock evasion when reading pps_enable

[ Upstream commit 3b1c92f8e5371700fada307cc8fd2c51fa7bc8c1 ]

The assignment of pps_enable is protected by tmreg_lock, but the read
operation of pps_enable is not. So the Coverity tool reports a lock
evasion warning which may cause data race to occur when running in a
multithread environment. Although this issue is almost impossible to
occur, we'd better fix it, at least it seems more logically reasonable,
and it also prevents Coverity from continuing to issue warnings.

Fixes: 278d24047891 ("net: fec: ptp: Enable PPS output based on ptp clock")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Link: https://lore.kernel.org/r/20240521023800.17102-1-wei.fang@nxp.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 4e4efb8f1b275e85c5c7f69087e392dbae437a8d)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>