tree 38db0854a3b90a21447f7d015c6df7525e2b7ec8
parent 4743f83990614af6adb09ea7aa3c37b78c4031ab
author Vegard Nossum <vegard.nossum@oracle.com> 1467644580 -0400
committer Theodore Ts'o <tytso@mit.edu> 1467644580 -0400

ext4: don't call ext4_should_journal_data() on the journal inode

If ext4_fill_super() fails early, it's possible for ext4_evict_inode()
to call ext4_should_journal_data() before superblock options and flags
are fully set up.  In that case, the iput() on the journal inode can
end up causing a BUG().

Work around this problem by reordering the tests so we only call
ext4_should_journal_data() after we know it's not the journal inode.

Fixes: 2d859db3e4 ("ext4: fix data corruption in inodes with journalled data")
Fixes: 2b405bfa84 ("ext4: fix data=journal fast mount/umount hang")
Cc: Jan Kara <jack@suse.cz>
Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>