tree c663735f694254b8894398b8f03f5433d6da3966
parent db1b3cb8b825fb48230e12d00652500c9fa29e2e
author Roded Zats <rzats@paloaltonetworks.com> 1714665471 +0300
committer Vegard Nossum <vegard.nossum@oracle.com> 1717417793 +0000

rtnetlink: Correct nested IFLA_VF_VLAN_LIST attribute validation

[ Upstream commit 1aec77b2bb2ed1db0f5efc61c4c1ca3813307489 ]

Each attribute inside a nested IFLA_VF_VLAN_LIST is assumed to be a
struct ifla_vf_vlan_info so the size of such attribute needs to be at least
of sizeof(struct ifla_vf_vlan_info) which is 14 bytes.
The current size validation in do_setvfinfo is against NLA_HDRLEN (4 bytes)
which is less than sizeof(struct ifla_vf_vlan_info) so this validation
is not enough and a too small attribute might be cast to a
struct ifla_vf_vlan_info, this might result in an out of bands
read access when accessing the saved (casted) entry in ivvl.

Fixes: 79aab093a0b5 ("net: Update API for VF vlan protocol 802.1ad support")
Signed-off-by: Roded Zats <rzats@paloaltonetworks.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Link: https://lore.kernel.org/r/20240502155751.75705-1-rzats@paloaltonetworks.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 8ac69ff2d0d5be9734c4402de932aa3dc8549c1a)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>