tree 60d7984d0b06031b9e0ccdd7a6cea66496431156
parent 9da7f2b727fd54add9890e238847acf82d6807a1
author Masahiro Yamada <masahiroy@kernel.org> 1707049203 +0900
committer Vegard Nossum <vegard.nossum@oracle.com> 1721065470 +0000

x86/kconfig: Select ARCH_WANT_FRAME_POINTERS again when UNWINDER_FRAME_POINTER=y

[ Upstream commit 66ee3636eddcc82ab82b539d08b85fb5ac1dff9b ]

It took me some time to understand the purpose of the tricky code at
the end of arch/x86/Kconfig.debug.

Without it, the following would be shown:

  WARNING: unmet direct dependencies detected for FRAME_POINTER

because

  81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection")

removed 'select ARCH_WANT_FRAME_POINTERS'.

The correct and more straightforward approach should have been to move
it where 'select FRAME_POINTER' is located.

Several architectures properly handle the conditional selection of
ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER'
in arch/arm/Kconfig.debug.

Fixes: 81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Link: https://lore.kernel.org/r/20240204122003.53795-1-masahiroy@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 28a7a1f9571068bb2ddc8a11f0afe5dfa9863462)
[Vegard: fix trivial conflict in context due to missing commit
 06ec64b84c357693e9a5540de8eedfc775dbae12 ("Kconfig: consolidate the
 "Kernel hacking" menu").]
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>