commit 4a02462af1f4c3498e6a330ffd5c063118309b31
author Roel Kluin <roel.kluin@gmail.com> Tue Dec 08 14:08:59 2009 -0800
committer James Bottomley <James.Bottomley@suse.de> Mon Jan 18 10:48:07 2010 -0600
tree 17c1f3ecb569c73dc5c33d185ca5dc4858b14808
parent 8fe79162a6807bf120140d64e96da54fc273b88b

[SCSI] u14-34f: fix buffer overflow

This allows i == MAX_INT_PARAM, which is out of range for ints[]

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

drivers/scsi/u14-34f.c

diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 54023d41..26e8e0e 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -1070,7 +1070,7 @@
    char *cur = str;
    int i = 1;
 
-   while (cur && isdigit(*cur) && i <= MAX_INT_PARAM) {
+   while (cur && isdigit(*cur) && i < MAX_INT_PARAM) {
       ints[i++] = simple_strtoul(cur, NULL, 0);
 
       if ((cur = strchr(cur, ',')) != NULL) cur++;