tree 0fac89df5f2749e21a45d2c07cf99d16e05ef2fc
parent 0fb0a4f00aaf5de9f328273d7a46e3aa27dab496
author Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> 1274383678 -0700
committer Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> 1274383678 -0700

wimax/i2400m: fix bad race condition check in RX path

The i2400m->rx_roq data structure is protected against race conditions
with a reference count (i2400m->rx_roq_refcount); the pointer can be
read-referenced under the i2400m->rx_lock spinlock.

The code in i2400m_rx_edata() wasn't properly following access
protocol, performing an invalid check on i2400m->rx_roq (which is
cleared to NULL when the refcount drops to zero). As such, it was
missing to detect when the data structure is no longer valid and
oopsing with a NULL pointer dereference.

This commit fixes said check by verifying, under the rx_lock spinlock,
that i2400m->rx_roq is non-NULL and then increasing the reference
count before dropping the spinlock.

Signed-off-by: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>