tree 435deca625d8099d60b23c0582272a8941ee3cc4
parent 3d986276f8b5fa0dc170e1b35f0659b9ba4b2cd0
author Bui Quang Minh <minhquangbui99@gmail.com> 1713969860 +0700
committer Vegard Nossum <vegard.nossum@oracle.com> 1720426497 +0000

scsi: bfa: Ensure the copied buf is NUL terminated

[ Upstream commit 13d0cecb4626fae67c00c84d3c7851f6b62f7df3 ]

Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from
userspace to that buffer. Later, we use sscanf on this buffer but we don't
ensure that the string is terminated inside the buffer, this can lead to
OOB read when using sscanf. Fix this issue by using memdup_user_nul instead
of memdup_user.

Fixes: 9f30b674759b ("bfa: replace 2 kzalloc/copy_from_user by memdup_user")
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-3-f1f1b53a10f4@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 481fc0c8617304a67649027c4a44723a139a0462)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>