commit bfd5834e38886031625fe39dc6f3907b9c382729
author Andy Shevchenko <andriy.shevchenko@linux.intel.com> Tue Mar 12 16:44:28 2019 +0200
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Sat Apr 20 09:15:00 2019 +0200
tree 231cb65140580c1172602d421010f2ad1a96b310
parent b042245be24b0e663bcf45f0ae77910bb3f11829

auxdisplay: hd44780: Fix memory leak on ->remove()

[ Upstream commit 41c8d0adf3c4df1867d98cee4a2c4531352a33ad ]

We have to free on ->remove() the allocated resources on ->probe().

Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

drivers/auxdisplay/hd44780.c

diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 036eec4..2d927fe 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -302,6 +302,8 @@ static int hd44780_remove(struct platform_device *pdev)
 	struct charlcd *lcd = platform_get_drvdata(pdev);
 
 	charlcd_unregister(lcd);
+
+	kfree(lcd);
 	return 0;
 }