commit 6ce00cae684e7c6310e14634320184ca3c011750
author Roel Kluin <roel.kluin@gmail.com> Thu Mar 11 14:09:35 2010 -0800
committer James Bottomley <James.Bottomley@suse.de> Sun Apr 11 09:23:31 2010 -0500
tree abb0e1d37e46a6bbe3a52f52cbc257083fe875b2
parent e05a9e7b18dfcce6911d0b901d7f04387cc1d93c

[SCSI] gdth: fix buffer overflow

This allows i == MAXHA, which is out of range

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

drivers/scsi/gdth.c

diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 35a4b30..a765fe7 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -3842,7 +3842,7 @@
 
     TRACE2(("option_setup() str %s\n", str ? str:"NULL")); 
 
-    while (cur && isdigit(*cur) && i <= MAXHA) {
+    while (cur && isdigit(*cur) && i < MAXHA) {
         ints[i++] = simple_strtoul(cur, NULL, 0);
         if ((cur = strchr(cur, ',')) != NULL) cur++;
     }