commit 21d0c83302fb742b7ffb6089d40196166102f5ed
author Herbert Xu <herbert@gondor.apana.org.au> Wed Sep 19 10:45:02 2007 -0700
committer David S. Miller <davem@sunset.davemloft.net> Thu Sep 20 12:14:16 2007 -0700
tree b11439340d1bb097867b57589fc4b6ce2f371a6a
parent 5588b40d7c2bff75ee573ed42d1738c73ce24492

[PPP] pppoe: Fix double-free on skb after transmit failure

When I got rid of the second packet in __pppoe_xmit I created
a double-free on the skb because of the goto abort on failure.
This patch removes that.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/pppoe.c

diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index 0d7f570..9b30cd6 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -879,8 +879,7 @@
 	dev->hard_header(skb, dev, ETH_P_PPP_SES,
 			 po->pppoe_pa.remote, NULL, data_len);
 
-	if (dev_queue_xmit(skb) < 0)
-		goto abort;
+	dev_queue_xmit(skb);
 
 	return 1;