commit a73acbb27cbe45c9ffbbbff751cb5f87b737693a
author Arian <arian.kulmer@web.de> Wed Oct 13 12:44:09 2021 +0200
committer Matsvei Niaverau <matvej2002@gmail.com> Mon Jan 02 23:29:20 2023 +0100
tree 6f50903221523775374be213426fa0cbcee8763f
parent 819783c314f96f20942d6e3bf6ffd3689249b616

Revert "power-libperfmgr: simply wait if idle state node is not present"

This reverts commit 297888275a44b3ce0e75fb1b50bea5108fc67459.

Change-Id: Iefee44a1f407729e76cb693832bad4998141c42b

aidl/power-libperfmgr/InteractionHandler.cpp

diff --git a/aidl/power-libperfmgr/InteractionHandler.cpp b/aidl/power-libperfmgr/InteractionHandler.cpp
index 23ced5c..6461466 100644
--- a/aidl/power-libperfmgr/InteractionHandler.cpp
+++ b/aidl/power-libperfmgr/InteractionHandler.cpp
@@ -65,14 +65,15 @@
     if (mState != INTERACTION_STATE_UNINITIALIZED)
         return true;
 
-    mIdleFd = fb_idle_open();
+    int fd = fb_idle_open();
+    if (fd < 0)
+        return false;
+    mIdleFd = fd;
 
     mEventFd = eventfd(0, EFD_NONBLOCK);
     if (mEventFd < 0) {
         ALOGE("Unable to create event fd (%d)", errno);
-        if (mIdleFd >= 0) {
-            close(mIdleFd);
-        }
+        close(mIdleFd);
         return false;
     }
 
@@ -95,9 +96,7 @@
     mThread->join();
 
     close(mEventFd);
-    if (mIdleFd >= 0) {
-        close(mIdleFd);
-    }
+    close(mIdleFd);
 }
 
 void InteractionHandler::PerfLock() {
@@ -213,18 +212,6 @@
         return;
     }
 
-    if (mIdleFd < 0) {
-        ret = poll(pfd, 1, timeout_ms);
-        if (ret > 0) {
-            ALOGV("%s: wait for duration aborted", __func__);
-            return;
-        } else if (ret < 0) {
-            ALOGE("%s: Error on waiting for duration (%zd)", __func__, ret);
-            return;
-        }
-        return;
-    }
-
     ret = pread(mIdleFd, data, sizeof(data), 0);
     if (!ret) {
         ALOGE("%s: Unexpected EOF!", __func__);